Fix inefficient spatial covariance calculation and parameter mapping in uncertainty SA#3965
Open
man080107 wants to merge 3 commits into
Open
Fix inefficient spatial covariance calculation and parameter mapping in uncertainty SA#3965man080107 wants to merge 3 commits into
man080107 wants to merge 3 commits into
Conversation
Simplified the calcSpatialCov.matrix function to directly return the spatial covariance matrix based on the input parameters.
mdietze
approved these changes
Apr 29, 2026
Member
mdietze
left a comment
mdietze
left a comment
There was a problem hiding this comment.
In the future, I'd recommend that separate bugs be separate issues and PRs. These two fixes have absolutely no relationship with one another.
Also, can you confirm that the cov calculation has been tested and does indeed return an object of the correct format, dimensions, and values?
mdietze
reviewed
Apr 29, 2026
mdietze
reviewed
May 15, 2026
Member
There was a problem hiding this comment.
Unclear why this was added to the function since it's unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3964