Skip to content

Bug:Fix bitwise AND typo in sipnet.c#235

Merged
Alomir merged 1 commit intoPecanProject:masterfrom
Labreo:patch-3
Jan 26, 2026
Merged

Bug:Fix bitwise AND typo in sipnet.c#235
Alomir merged 1 commit intoPecanProject:masterfrom
Labreo:patch-3

Conversation

@Labreo
Copy link
Copy Markdown
Contributor

@Labreo Labreo commented Jan 26, 2026

Summary

  • Motivation: The current logic for calcRootAndWoodFluxes() has a bug where it uses bitwise operation(&) for boolean comparison instead of (&&).
  • What: Added && instead of & to add boolean logic.

How to test

Steps to reproduce and verify the change locally:

make
cd tests/smoke/<new-or-updated-test> ../../sipnet -i sipnet.in

Related issues

  • Fixes # (or "Relates to #N" if this is not a resolution of that ticket)

Checklist

  • Tests added for new features
  • Documentation updated (if applicable)
  • docs/CHANGELOG.md updated with noteworthy changes
  • Code formatted with clang-format (run git clang-format if needed)
  • Requested review from at least one CODEOWNER

For model structure changes:

  • Removed \fraktur font formatting from docs/model-structure.md for implemented features

Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run git clang-format to format staged changes.

@Labreo Labreo changed the title Bug:Fix bitwise AND typo in sipnet.c Critical Bug:Fix bitwise AND typo in sipnet.c Jan 26, 2026
@Labreo Labreo changed the title Critical Bug:Fix bitwise AND typo in sipnet.c Bug:Fix bitwise AND typo in sipnet.c Jan 26, 2026
Copy link
Copy Markdown
Collaborator

@Alomir Alomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Alomir Alomir merged commit ca4812d into PecanProject:master Jan 26, 2026
11 checks passed
ayushman1210 pushed a commit to ayushman1210/sipnet that referenced this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants