Fix crossing frames wrongly counts movement endling on line#376
Merged
schroedtert merged 4 commits intoPedestrianDynamics:mainfrom Sep 27, 2024
Merged
Conversation
schroedtert
force-pushed
the
fix-crossing-frames-wrong-counts
branch
from
114ea5f to
d1db85b
Compare
schroedtert
force-pushed
the
fix-crossing-frames-wrong-counts
branch
from
d1db85b to
cacb083
Compare
schroedtert
force-pushed
the
fix-crossing-frames-wrong-counts
branch
from
cacb083 to
fa2fa64
Compare
These adaptions are needed, as the passing speed and density computations are working differently, they count the crossing frames already when a pedestrian is touching the line. These function call the internal helper function, and compute_crossing_frames calls the helper function with a specific setting.
schroedtert
force-pushed
the
fix-crossing-frames-wrong-counts
branch
from
fa2fa64 to
b09b94b
Compare
chraibi
previously approved these changes
Sep 26, 2024
Collaborator
chraibi
left a comment
chraibi
left a comment
There was a problem hiding this comment.
My comments are minor, such that you can go ahead an merge this PR after considering changes.
schroedtert
force-pushed
the
fix-crossing-frames-wrong-counts
branch
from
f746e42 to
341f3cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #375