Open
Conversation
Audit 4 test files for capture-mode compatibility: - test_gradient.py: 46 tests converted, 23 capture_todo - test_gradient_postprocessing.py: 12 tests converted, 11 capture_todo - test_adjoint.py: 8 tests converted, 6 capture_todo - test_jvpvjp.py: 1 test converted, 1 capture_todo conftest.py: strict xfail for capture_todo (strict=True) Results: 649 pass, 85 xfail, 0 new failures Progress: 8 tests fixed since story-4 v1 (WI-7/WI-8 confirmed)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2623 +/- ##
=======================================
Coverage 96.99% 97.00%
=======================================
Files 157 157
Lines 17450 17470 +20
Branches 1684 1686 +2
=======================================
+ Hits 16926 16946 +20
Misses 387 387
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrijapau
reviewed
Mar 25, 2026
Contributor
|
Hello. You may have forgotten to update the changelog!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradients tests used to have a PR, but it was causing too many conflicts very complicated to resolve. Hence remake
Some changes:
Considering the potential conflicts, I think we better not touching the exiting
use_both_frontendfor now. Just apply thecapture_modeto those who haven't been tested with both.