[qref 3.4] Migrate while loop's plxpr conversion to reference semantics#2717
Merged
paul0403 merged 84 commits intopaul0403/qref_frontend_mainfrom Apr 23, 2026
Merged
Conversation
8 tasks
albi3ro
approved these changes
Apr 23, 2026
Contributor
albi3ro
left a comment
albi3ro
left a comment
There was a problem hiding this comment.
❤️
Similar comment as to for_loop PR. This looks amazing! And going to trust you that the CI will all come together.
Base automatically changed from
paul0403/qref_frontend_forloop
to
paul0403/qref_frontend_main
April 23, 2026 15:33
JerryChen97
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Migrate while loop's plxpr conversion to reference semantics
Description of the Change:
Delete the conversion from plxpr while loop primitive to catalyst while loop primitive, so we just use the lowering of plxpr while loop primitive directly.
Benefits:
Much cleaner conversion of plxpr to catalys jaxpr.
[sc-115871]