Skip to content

Add type conversion patterns for the convert-qecp-to-quantum pass#2809

Merged
multiphaseCFD merged 26 commits into
mainfrom
shuli/qecp-to-quantum-types-conversion
May 19, 2026
Merged

Add type conversion patterns for the convert-qecp-to-quantum pass#2809
multiphaseCFD merged 26 commits into
mainfrom
shuli/qecp-to-quantum-types-conversion

Conversation

@multiphaseCFD
Copy link
Copy Markdown
Member

@multiphaseCFD multiphaseCFD commented May 7, 2026

Before submitting

Please complete the following checklist when submitting a PR:

  • All new functions and code must be clearly commented and documented.

  • Ensure that code is properly formatted by running make format.
    The latest version of black and clang-format-20 are used in CI/CD to check formatting.

  • All new features must include a unit test.
    Integration and frontend tests should be added to frontend/test,
    Quantum dialect and MLIR tests should be added to mlir/test, and
    Runtime tests should be added to runtime/tests.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Add type conversion patterns for : 1. PhysicalCodeblockType; 2. QecPhysicalQubitType,

Note that:

  • PhysicalHyperRegisterType conversion would be included in the alloc, dealloc, insert_codeblock and extract_codeblock lowering
  • TannerGraphType would be included in the qecp-to-llvm lowering

[sc-119019]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD changed the base branch from main to shuli/add-qecp-to-quantum-skeleton-pass May 11, 2026 17:52
Base automatically changed from shuli/add-qecp-to-quantum-skeleton-pass to main May 11, 2026 18:35
@multiphaseCFD multiphaseCFD marked this pull request as ready for review May 11, 2026 19:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.96%. Comparing base (ead5a37) to head (022a30d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2809   +/-   ##
=======================================
  Coverage   96.95%   96.96%           
=======================================
  Files         169      169           
  Lines       18876    18888   +12     
  Branches     1799     1799           
=======================================
+ Hits        18301    18314   +13     
+ Misses        409      408    -1     
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread frontend/catalyst/python_interface/transforms/qecp/convert_qecp_to_quantum.py Outdated
Comment thread frontend/catalyst/python_interface/transforms/qecp/convert_qecp_to_quantum.py Outdated
@joeycarter joeycarter self-requested a review May 11, 2026 21:04
Copy link
Copy Markdown
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test (or tests) for converting !qecp.qubit types (data and aux) to !quantum.bit types?

@multiphaseCFD
Copy link
Copy Markdown
Member Author

Could you also add a test (or tests) for converting !qecp.qubit types (data and aux) to !quantum.bit types?

Done!

@multiphaseCFD multiphaseCFD requested a review from joeycarter May 11, 2026 22:41
Copy link
Copy Markdown
Contributor

@joeycarter joeycarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @multiphaseCFD!

@multiphaseCFD multiphaseCFD requested review from paul0403 May 13, 2026 19:33
Copy link
Copy Markdown
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @multiphaseCFD! 🚀

@multiphaseCFD multiphaseCFD merged commit 856299c into main May 19, 2026
39 checks passed
@multiphaseCFD multiphaseCFD deleted the shuli/qecp-to-quantum-types-conversion branch May 19, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants