Various fixes to the to_ppr pass#2896
Merged
Merged
Conversation
Any gate-like operation from the quantum dialect must be converted to PPR form. We can use our interfaces and dynamic legality to do this robustly.
Since these are not supported in the conversion. Only CNOT (as an explicit gate, not controlled-X) is supported.
Using an interface pattern allows us to cover all the quantum ops we marked illegal, without having to register them one-by-one (which is sensitive to future changes).
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2896 +/- ##
==========================================
- Coverage 97.01% 97.01% -0.01%
==========================================
Files 167 167
Lines 18830 18873 +43
Branches 1770 1772 +2
==========================================
+ Hits 18268 18309 +41
- Misses 417 418 +1
- Partials 145 146 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sengthai
approved these changes
Jun 1, 2026
kipawaa
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following has been changed:
fixes #2886
[sc-121168]