Skip to content

Conversation

@PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Mar 20, 2025

Context: This PR should be merged after this one is merged in pennylane-lightning. That is, after the jaxpr_jvp method has been implemented for lightning devices, so that we can compute gradients with lightning.qubit

Description of the Change: As above.

Benefits: We can differentiate using lightning.qubit

Possible Drawbacks: None.

Related GitHub Issues: None.

[sc-86927]

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@PietropaoloFrisoni PietropaoloFrisoni added the do not merge ⚠️ Do not merge the pull request until this label is removed label Mar 20, 2025
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@PietropaoloFrisoni PietropaoloFrisoni removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Mar 21, 2025
@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) March 21, 2025 16:11
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (3f589f8) to head (6d42f13).
Report is 348 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7125   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files         503      503           
  Lines       49024    49024           
=======================================
  Hits        48839    48839           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PietropaoloFrisoni PietropaoloFrisoni merged commit 35f705f into master Mar 21, 2025
48 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the test_gradient_with_lightning branch March 21, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants