Bring Portal Core and Mobile Control into Essentials#1225
Merged
Conversation
added 18 commits
March 24, 2025 22:28
In order to solve some dependency issues that keep cropping up, MC should be moved back into the Essentials repo and loaded automatically on startup. This will allow for all plugins that use the MC Messengers library to use the same version without fear of overwriting a dll due to loading of plugin libraries.
In order to prevent eventual version collision and confusion, and to allow for deprecation of existing packages, the names of the MC packages are now reflective of the fact that they are no longer pluginsbuild(force-patch): change names of MC packages In order to prevent eventual version collision and confusion, and to allow for deprecation of existing packages, the names of the MC packages are now reflective of the fact that they are no longer plugins.
CPLZs are not required for using Essentials as a dependency, and just adds noise that's not required.
In an effort to make it easier to use the logging mechanism, I added 4 overloaded methods for each level to allow for logging exceptions at any level, not just error. I also added overloads for each level to the extensions so that an exception can be logged at any level, not just error.
added 2 commits
March 26, 2025 08:55
Some constructors for messengers were taking Device rather than the specific type they needed.
This has been replaced by the `IHasInputs<T>` interface and was marked to be removed in the 2.0.0 release.
ndorin
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also did some clean up on what debug methods were used, as well as suggestions from Roslyn.