Skip to content

fix: add null check for room before adding to DevManager#1230

Merged
ndorin merged 1 commit into
mainfrom
room-loading-protections
Mar 31, 2025
Merged

fix: add null check for room before adding to DevManager#1230
ndorin merged 1 commit into
mainfrom
room-loading-protections

Conversation

@andrew-welker
Copy link
Copy Markdown
Contributor

No description provided.

@andrew-welker andrew-welker requested review from Copilot and ndorin March 31, 2025 17:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix an issue where a null room is added to the DeviceManager by introducing a null check before adding a room.

  • Added a null check to ensure that a room is not added if it is null
  • Added a warning log message to aid in debugging when a room cannot be loaded

Comment thread src/PepperDash.Essentials/ControlSystem.cs
@ndorin ndorin merged commit d3719ee into main Mar 31, 2025
2 checks passed
@ndorin ndorin deleted the room-loading-protections branch March 31, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants