Add IHasWebview interface#1232
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an interface for web view handling on codecs and updates a GitHub Actions workflow configuration.
- Added the IHasWebView interface in the Core library to support web view operations.
- Updated the GitHub Actions workflow to bypass package checks during builds.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWebView.cs | Added new interface for handling web view operations. |
| .github/workflows/EssentialsPlugins-builds-4-series-caller.yml | Modified workflow config to bypass package checks. |
Comments suppressed due to low confidence (1)
src/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWebView.cs:11
- [nitpick] Consider renaming 'WebviewIsVisible' to 'WebViewIsVisible' to maintain consistent PascalCase naming conventions.
bool WebviewIsVisible { get; }
andrew-welker
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds interface for web view handling on a codec