fix: ILightingScenesDynamic inherits from ILightingScenes#1256
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an inheritance issue in the lighting interfaces and improves the generic design for selectable items.
- ILightingScenesDynamic now properly inherits from ILightingScenes.
- ISelectableItems is refactored to support an additional generic type parameter, with a new overload for backward compatibility.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/Lighting/Lighting Interfaces.cs | Updated ILightingScenesDynamic to inherit from ILightingScenes. |
| src/PepperDash.Essentials.Core/DeviceTypeInterfaces/ISelectableItems.cs | Expanded ISelectableItems to include a two-parameter generic interface and provided an overload for the legacy interface. |
jkdevito
approved these changes
Apr 18, 2025
ndorin
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.