fix: exclude examples from turbo lint in CI#311
Merged
Conversation
Examples use 'next lint' instead of ESLint directly, causing CI to fail with: Invalid project directory: examples/stackwright-docs/lint The lint task in CI was including all workspace packages (including examples) via pnpm turbo:lint. Excluding examples from the lint task fixes this. Closes #310
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
Contributor
♿ Accessibility Test ResultsOverall Status: ✅ 0/0 tests passed 🦮 WCAG 2.1 AA ComplianceNo WCAG test results available ⌨️ Keyboard NavigationNo keyboard navigation test results available 📊 Detailed ReportDownload the full HTML accessibility report from the workflow artifacts for:
🔍 Testing ChecklistOur accessibility tests verify:
Powered by @axe-core/playwright and Playwright |
perasperaactual
added a commit
that referenced
this pull request
Apr 7, 2026
* refactor(otters): relocate to packages/otters/src/ for proper monorepo structure (#299) * chore: bump prerelease versions [skip ci] * chore: refresh prerelease mode after v0.7.0 release [skip ci] * fix(ci): add push trigger to release workflow for main branch * feat: add Turborepo for incremental builds and intelligent caching (#304) * docs: add architecture principles and CI philosophy (#301) * feat: add Turborepo for incremental builds and intelligent caching (#305) * fix: enable npm OIDC provenance and update branching docs - Add provenance: true to setup-node in prerelease and release workflows - Replace pnpm publish -r with npm publish --provenance loop - npm publish supports native OIDC authentication - Update CLAUDE.md and CONTRIBUTING.md to emphasize dev branch targeting Aligns with pro repo publishing strategy. * fix: merge duplicate env blocks in ci.yml YAML doesn't allow duplicate keys at the same level. * chore: clean up consumed changesets Remove 27 stale changeset files that have already been applied and update stackwright-docs package.json if needed * chore: sync pnpm-lock.yaml with package.json Regenerate lockfile to fix frozen-lockfile CI failure. * fix: add missing react-dom dependency to stackwright-docs The package.json was missing react-dom as an explicit dependency, causing frozen-lockfile CI failures. Add it and regenerate lockfile. * docs: update CLAUDE.md and CONTRIBUTING.md, add .turbo/ to gitignore (#307) * fix: exclude @stackwright/ui-shadcn from test commands (#309) The ui-shadcn package has no test files (it's a thin adapter over Radix UI + Tailwind CSS). Excluding it from test commands prevents vitest from failing with 'No test files found' error. * fix: exclude examples from turbo lint in CI (#311) Examples use 'next lint' instead of ESLint directly, causing CI to fail with: Invalid project directory: examples/stackwright-docs/lint The lint task in CI was including all workspace packages (including examples) via pnpm turbo:lint. Excluding examples from the lint task fixes this. Closes #310 --------- Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI workflow runs
pnpm turbo:lintwhich includes all workspace packages (including examples). However, examples usenext lintinstead of ESLint directly, causing the error:Changes
package.jsonturbo:lintscript to exclude examples:turbo lintturbo lint --filter='!./examples/**'Verification
pnpm turbo:lint --dry-runnow only targets packages inpackages/directory, excluding examples.Fixes CI failure in PR #310