fix(a11y): add tabIndex=-1 to main landmark + harden skip-link e2e test#474
Merged
Merged
Conversation
…st (stackwright-8c4)
- Add tabIndex={-1} to <main id="main-content"> so activating the
skip-to-content link actually moves keyboard focus (not just scrolls)
- Harden skip-link e2e test from soft console.warn to hard expect assertion
- Skip SSR test that was incorrect for App Router static export (stackwright-pzr)
Contributor
✅ Visual Regression Test ResultsStatus: ✅ All visual tests passed! All screenshots match the baseline. No visual regressions detected! 🎉 |
Contributor
⚡ Performance Benchmark Results✅ Build Time Benchmarks: PASSED❌ Bundle Size Benchmarks: FAILED❌ Runtime Vitals Benchmarks: FAILED📝 Note: Detailed results are available in the job logs. 🎯 Performance Budgets:
Updated: 2026-05-31T14:02:21.329Z |
Contributor
♿ Accessibility Test ResultsOverall Status: ✅ 0/0 tests passed 🦮 WCAG 2.1 AA ComplianceNo WCAG test results available ⌨️ Keyboard NavigationNo keyboard navigation test results available 📊 Detailed ReportDownload the full HTML accessibility report from the workflow artifacts for:
🔍 Testing ChecklistOur accessibility tests verify:
Powered by @axe-core/playwright and Playwright |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes stackwright-8c4 (P1 a11y) and stackwright-pzr (P2 e2e test fix).
Changes
packages/core/src/components/structural/PageLayout.tsxtabIndex={-1}to<main id="main-content">— the skip-to-content link already existed as the first focusable element, but withouttabIndex={-1}on the target, keyboard focus did not actually move to the main content area when the skip link was activated. This is required for WCAG 2.4.1 Level A compliance.packages/e2e/tests/a11y/keyboard-navigation.spec.tsifcheck (console.warn only) to a hard assertion that fails CI if the skip link is absent or non-functional.packages/e2e/tests/edge-cases/error-scenarios.spec.tsoutput: 'export'is intentionally client-rendered — the framework is correct, the test was wrong.Testing
pnpm testpassespnpm lintpasses@stackwright/core(patch)