SPI-Master, SDCard Updates#146
Merged
Merged
Conversation
PerMalmberg
requested changes
Mar 19, 2021
Owner
PerMalmberg
left a comment
PerMalmberg
left a comment
There was a problem hiding this comment.
Nice to see it didn't require large changes to the existing code base.
PerMalmberg
requested changes
Mar 22, 2021
PerMalmberg
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to SPI-Master and SDCard using latest esp-idf.
Changes to test programs to run with SPI-Master and SDCard.
Updated mock-idf - also ran uncrustify on mock-idf files from Wifi update(#143), should have done that before sorry.
Tested on M5Stack which has the SDCard and LCD display on same spi-bus. I do not have hardware to test the MMC card.