update docker image#151
Merged
Merged
Conversation
Contributor
Author
|
the failing CI check is because of the change in the docker image which hast to be re-generated. |
Owner
|
Welcome, new contributor :) You can temporarily push your docker image to docker hub and update the build script to use that image to ensure it also passes in CI. Once done, it can be reverted and I'll push a new image based on the changes which will make this PR pass. gdb isn't really needed in the image, no. |
Contributor
Author
|
@PerMalmberg all green :) |
Owner
|
Great. Revert the image, remove the commented stuff and I'll merge and push an updated 'official' smooth build image. |
This reverts commit b994227.
Contributor
Author
|
i reverted the docker image change and removed the not needed lines in the docker file. From my side it is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on #115 and I wanted to share the first draft.
It is already running on my lokal machine. please dubble check and make some comments if you are not or happy with the changes.
There are still a lot of lines commented out, I will remove them when you are fine with it - as an example: do you need gdb in the docker image? etc.