Skip to content

update docker image#151

Merged
PerMalmberg merged 10 commits into
PerMalmberg:masterfrom
peterus:master
Apr 5, 2021
Merged

update docker image#151
PerMalmberg merged 10 commits into
PerMalmberg:masterfrom
peterus:master

Conversation

@peterus
Copy link
Copy Markdown
Contributor

@peterus peterus commented Apr 1, 2021

I am working on #115 and I wanted to share the first draft.
It is already running on my lokal machine. please dubble check and make some comments if you are not or happy with the changes.
There are still a lot of lines commented out, I will remove them when you are fine with it - as an example: do you need gdb in the docker image? etc.

@peterus
Copy link
Copy Markdown
Contributor Author

peterus commented Apr 1, 2021

the failing CI check is because of the change in the docker image which hast to be re-generated.

@PerMalmberg
Copy link
Copy Markdown
Owner

Welcome, new contributor :)

You can temporarily push your docker image to docker hub and update the build script to use that image to ensure it also passes in CI. Once done, it can be reverted and I'll push a new image based on the changes which will make this PR pass.

gdb isn't really needed in the image, no.

@peterus
Copy link
Copy Markdown
Contributor Author

peterus commented Apr 3, 2021

@PerMalmberg all green :)

@PerMalmberg
Copy link
Copy Markdown
Owner

Great. Revert the image, remove the commented stuff and I'll merge and push an updated 'official' smooth build image.

@peterus
Copy link
Copy Markdown
Contributor Author

peterus commented Apr 4, 2021

i reverted the docker image change and removed the not needed lines in the docker file. From my side it is ready to merge.

@PerMalmberg PerMalmberg merged commit 5c15adf into PerMalmberg:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants