Skip to content

prevent backup.mongodump.compression 'none' to be overwritten #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

prevent backup.mongodump.compression 'none' to be overwritten #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions mongodb_consistent_backup/Backup/Mongodump/Mongodump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ def __init__(self, manager, config, timer, base_dir, backup_dir, replsets, shard
with hide('running', 'warnings'), settings(warn_only=True):
self.version = local("%s --version|awk 'NR >1 {exit}; /version/{print $NF}'" % self.binary, capture=True)

if self.can_gzip():
if self.compression() == 'none':
self.compression('gzip')
elif self.compression() == 'gzip':
if not self.can_gzip() and self.compression() == 'gzip':
logging.warning("mongodump gzip compression requested on binary that does not support gzip!")

def can_gzip(self):
Expand Down
2 changes: 1 addition & 1 deletion scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ if [ -d ${srcdir} ]; then
source ${venvdir}/bin/activate

[ ! -d ${pipdir} ] && mkdir -p ${pipdir}
${venvdir}/bin/python2.7 ${venvdir}/bin/pip install --download-cache=${pipdir} pex requests
${venvdir}/bin/python2.7 ${venvdir}/bin/pip install --cache-dir=${pipdir} pex requests
if [ $? -gt 0 ]; then
echo "Failed to install pex utility for building!"
exit 1
Expand Down