Fix: Missing zero address validation in permit() #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permit() function was missing zero address validation for the spender parameter, allowing gasless approvals to the zero address which violates the ERC-20 standard and EIP-2612 best practices. This fix adds spender validation at the beginning of permit(), ensuring consistency with the approve() function and preventing invalid permits.
Contributor
|
Thanks for your help with this! |
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…alidation Fix: Missing zero address validation in permit()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
The permit() function was missing zero address validation for the spender parameter, allowing gasless approvals to the zero address which violates the ERC-20 standard and EIP-2612 best practices.
This fix adds spender validation at the beginning of permit(), ensuring consistency with the approve() function and preventing invalid permits.