Re-enable Forge Formatting Check in CI

[adamgall]

Summary

This PR re-enables the forge fmt --check step in the GitHub Actions workflow that was previously commented out.

Context

The Forge formatting check was temporarily disabled in a previous commit to unblock CI. After fixing formatting issues in the codebase (commit df942e7), we can now safely re-enable this check to maintain code formatting standards going forward.

Changes

• Uncommented the Run Forge fmt step in .github/workflows/test.yml
• This will now enforce consistent Solidity code formatting on all PRs

Testing

• CI should pass with the formatting check enabled
• All existing tests should continue to pass

Impact

This ensures that all future code contributions maintain consistent formatting standards, improving code readability and reducing formatting-related conflicts in PRs.

Related Issue

Closes #36

[mudgen]

I agree with this. But first I need to provide better contributor documentation to people adding code know that they need to pass forge fmt --check before submitting a merge request so I don't reject it for that reason. I will add that documentation. Thanks for making this pull request and I'll merge it later.

[adamgall]

I'll just push up that documentation in this PR. Gimme a min.

edit: all done @mudgen

[maxnorm]

Before stuffing contribution requirements inside the README, we can add a CONTRIBUTION.md file with all the related infos like your change.

This can have it's own issue if needed

[maxnorm]

Hi @adamgall, i've created a new CONTRIBUTING.md file to keep all the requirements in 1 file and avoid complicating the README with the contribution infos.

Can you resolve conflicts and add you formatting doc in the CONTRIBUTING.md where it feel the more natural.

We mention it in the Dev Workflow at line 75 but feel free to add a new section if needed

Thanks

[adamgall]

@maxnorm i fixed the merge conflicts, but it looks like the github action has failed. seems like all of the jobs are failing since this commit: 69cd70a

[mudgen]

I fixed the github action. Merging this.