standardize internal function names#43
standardize internal function names#43ely67 wants to merge 3 commits intoPerfect-Abstractions:mainfrom
Conversation
| /// @param _tokenId The token ID to approve. | ||
| function approve(address _to, uint256 _tokenId) external { | ||
| <<<<<<< HEAD | ||
| ERC721Storage storage s = _getStorage(); |
|
Hi guys, I think that most internal functions (not including getStorage()) in Compose will come from libraries like LibERC20.sol. These libraries are intended to be used by users of Compose when they write their own custom facets that integrate with our facets (like ERC20Facet). So these internal functions will already be prefixed with the library name when they are used, for example: Because of how we are mainly using internal functions, I do not want to prefix them with "_". In Compose internal functions within facets (not libraries) are prefixed with "internal", but there should be none or few internal functions within facets. One of the things we need is a STYLE.md file that provides a concise style guide of Compose based on ERC20Facet.sol, LibERC20.sol, ERC721Facet and LibERC721.sol. |
3 participants
Summary
Refactor internal function names to use an underscore prefix across facets and libraries (ERC20, ERC721, ERC173). Improves readability and follows common Solidity style. No external ABI changes, no storage layout changes.