Remove unused ERC20InvalidApprover error#48
Merged
mudgen merged 1 commit intoPerfect-Abstractions:mainfrom Oct 21, 2025
Merged
Conversation
The ERC20InvalidApprover error was declared but never used anywhere in the codebase. Analysis shows it's not needed because: - approve() uses msg.sender as approver, which can never be address(0) - permit() signature verification would fail for address(0) anyway This error appears to have been included for ERC-6093 compliance but serves no practical purpose in the current implementation.
JackieXu
pushed a commit
to JackieXu/Compose
that referenced
this pull request
Nov 6, 2025
…-invalid-approver-error Remove unused ERC20InvalidApprover error
maxnorm
added a commit
that referenced
this pull request
Mar 25, 2026
[DOCS] Auto-generated Docs Pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
The ERC20InvalidApprover error was declared but never used anywhere in the codebase. Analysis shows it's not needed because:
This error appears to have been included for ERC-6093 compliance but serves no practical purpose in the current implementation.