Verify release asset contract#14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/...paths, so installer checksum verification works after downloading assets.OCVM_INSTALL_DRY_RUNplus uname overrides to verify installer target and asset selection without downloading or installing.scripts/check-release-prep.shand run it from CI alongside shell syntax checks.Why
The release workflow previously generated Unix checksum files with
dist/ocvm-...tar.gzin the checked filename.install.shdownloads archives into a temp directory asocvm-...tar.gz, sosha256sum -cwould not find the path from the checksum file.Validation
sh -n install.sh scripts/*.sh./scripts/check-release-prep.shcargo fmt --checkgit diff --checkcargo clippy --all-targets -- -D warningscargo testcargo build --releasecargo package --allow-dirty --offline-> 29 files, 29.5KiB compressedNot merging until review.