Bleadperl v5.27.6-120-gbcc30fd027 breaks GARU/Data-Printer-0.40.tar.gz

[p5pRT]

Migrated from rt.perl.org#132646 (status was 'resolved')

Searchable as RT132646$

[p5pRT]

From @andk

Kudos to Slaven for the discovery!

bisect

---

commit bcc30fd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Mon Dec 4 11​:50​:53 2017 +0000

  multiconcat​: don't fold adjacent constants

diagnostics

---

http​://www.cpantesters.org/cpan/report/82741a38-d967-11e7-9af2-f32bb5d65ef4

perl -V

---

Summary of my perl5 (revision 5 version 27 subversion 7) configuration​:
  Commit id​: bcc30fd
  Platform​:
  osname=linux
  osvers=4.12.0-2-amd64
  archname=x86_64-linux-thread-multi
  uname='linux k93msid 4.12.0-2-amd64 #1 smp debian 4.12.13-1 (2017-09-19) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.6-120-gbcc30fd027/419a -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Duseithreads -Uuselongdouble -DEBUGGING=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=define
  usemultiplicity=define
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
  optimize='-O2'
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='7.2.0'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  MULTIPLICITY
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_IMPLICIT_CONTEXT
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_ITHREADS
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Dec 4 2017 13​:02​:29
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.6-120-gbcc30fd027/419a/lib/site_perl/5.27.7/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.6-120-gbcc30fd027/419a/lib/site_perl/5.27.7
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.6-120-gbcc30fd027/419a/lib/5.27.7/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.27.6-120-gbcc30fd027/419a/lib/5.27.7

--
andreas

[p5pRT]

From @iabyn

On Sat, Dec 23, 2017 at 04​:11​:25AM -0800, Andreas J. Koenig via RT wrote​:

commit bcc30fd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Mon Dec 4 11​:50​:53 2017 +0000

multiconcat​: don't fold adjacent constants

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/82741a38-d967-11e7-9af2-f32bb5d65ef4

Now fixed​:

commit f08f2d0
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Dec 25 10​:40​:58 2017 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Dec 25 11​:21​:07 2017 +0000

  mutlitconcat​: fix non-folding adjacent consts
 
  RT ##132646
 
  v5.27.6-120-gbcc30fd changed multiconcat so that adjacent constants
  weren't folded, so that ($overloaded . "a" . "b") is invoked as
  $overloaded->concat("a")->concat("b")
  rather than
  $overloaded->concat("ab")
 
  It did this by 'demoting' every second adjacent const as a real arg rather
  than adding it to the const string. However, that could leave a
  multiconcat op with more than the maximum allowed args.
 
  So include demotion candidates as part of the arg count.

--
More than any other time in history, mankind faces a crossroads. One path
leads to despair and utter hopelessness. The other, to total extinction.
Let us pray we have the wisdom to choose correctly.
  -- Woody Allen

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @jkeenan

On Mon, 25 Dec 2017 11​:44​:23 GMT, davem wrote​:

On Sat, Dec 23, 2017 at 04​:11​:25AM -0800, Andreas J. Koenig via RT
wrote​:

commit bcc30fd
Author​: David Mitchell <davem@​iabyn.com>
Date​: Mon Dec 4 11​:50​:53 2017 +0000

multiconcat​: don't fold adjacent constants

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/82741a38-d967-11e7-9af2-
f32bb5d65ef4

Now fixed​:

commit f08f2d0
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Dec 25 10​:40​:58 2017 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Dec 25 11​:21​:07 2017 +0000

mutlitconcat​: fix non-folding adjacent consts

RT ##132646

v5.27.6-120-gbcc30fd changed multiconcat so that adjacent constants
weren't folded, so that ($overloaded . "a" . "b") is invoked as
$overloaded->concat("a")->concat("b")
rather than
$overloaded->concat("ab")

It did this by 'demoting' every second adjacent const as a real arg
rather
than adding it to the const string. However, that could leave a
multiconcat op with more than the maximum allowed args.

So include demotion candidates as part of the arg count.

Confirmed.

#####
$ ./bin/perl -v | head -2 | tail -1
This is perl 5, version 27, subversion 8 (v5.27.8 (v5.27.7-49-gf08f2d0)) built for x86_64-linux

$ ./bin/cpanm Data​::Printer
[snip]
Building and testing Data-Printer-0.40 ... OK
Successfully installed Data-Printer-0.40
14 distributions installed
#####
--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

@jkeenan - Status changed from 'open' to 'resolved'