Make pod2html remove leading whitespace from literal blocks #18031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings pod2html functionality similar to how Metacpan handles whitespace
scottchiefbaker
force-pushed
the
pod2html_normalize_whitespace
branch
from
deb3afa to
320e353
Compare
Contributor
|
This is definitely a good addition, one thing to consider is that this turns tabs into spaces as in metacpan/MetaCPAN-Pod-HTML#2 but this is probably not that important for this niche tool. |
scottchiefbaker
force-pushed
the
pod2html_normalize_whitespace
branch
from
f7a8181 to
e93e9f7
Compare
haarg
reviewed
Aug 3, 2020
Contributor
Author
|
@haarg updated the PR to reflect this |
scottchiefbaker
force-pushed
the
pod2html_normalize_whitespace
branch
from
3c167c4 to
64a9a8b
Compare
Contributor
|
It looks like we also need a version bump on some modules to fix the failing tests, before this can be merged |
Contributor
Author
|
I bumped the version, and fixed a couple of failing tests. |
Contributor
Author
|
This is just a ping to see what's next for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pod2htmlleaves the leading whitespace indentation in the HTML output. This PR removes leading whitespace so the <pre> output has an appropriate level of indentation.This brings pod2html functionality similar to how Metacpan handles whitespace