Skip to content

Conversation

@nwc10
Copy link
Contributor

@nwc10 nwc10 commented Oct 11, 2021

The paragraph starts:

On a related issue, old modules may possibly be affected by the changes in the Perl language in the current release.

Previously it made no indication about whether these changes were frequent or rare, small or large. The reality is that we are careful to keep them small and backwards compatible, whenever possible. So add the text:

We try hard to make new features "opt-in", such that existing code will work unchanged, and attempt to identify where bug fixes might expose code which was relying on incorrect interpreter behaviour.

@Grinnz
Copy link
Contributor

Grinnz commented Oct 11, 2021

The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms.

@Grinnz
Copy link
Contributor

Grinnz commented Oct 11, 2021

ExtUtils::Installed is a slightly more supported way to get a list of the currently installed modules, though it relies on packlists and has a few issues related to module-vs-distribution logic, and doesn't have a commandline interface.

@jkeenan
Copy link
Contributor

jkeenan commented Mar 2, 2022

The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms.

We should decide whether we're going to move forward with this older p.r. modifying INSTALL.

@nwc10, would you like to provide some feedback on @Grinnz's comments?

@demerphq
Copy link
Collaborator

demerphq commented Mar 12, 2022

I requested from Andreas on this. I mean @andk of course.

@andk
Copy link
Contributor

andk commented Mar 12, 2022

Thanks for bringing this to my attention. Autobundle is neither broken nor unsupported, I use it regularly. I'm not even aware of a convenient alternative. Perllocal is a different cattle of fish: if I remember correctly, it's older than autobundle and since I never use it, I'm not familiar anymore with it's strengths and weaknesses.

@demerphq
Copy link
Collaborator

IMO we should merge this as is, and then push a follow up PR to split up the paragraphs.

LGTM.

@demerphq
Copy link
Collaborator

demerphq commented Oct 11, 2022 via email

@jkeenan
Copy link
Contributor

jkeenan commented Jan 17, 2023

Hi Andreas, This was the thread/patch I was wondering if you could review. @Grinnz (Dan Book) says that autobundle is no longer supported. @nwc10 (Nicholas Clark) included a reference to it in a patch to INSTALL. The patch is stalled, and @jkeenan (James Keenan) is trying to find a way forward. Maybe you could clarify the situation for us? #19185 Cheers, yves

On Wed, 2 Mar 2022 at 14:36, James E Keenan @.> wrote: The last two sentences regarding perllocal and autobundle should probably be split to their own paragraph now. Or removed, as both of them are rather outdated and unsupported mechanisms. We should decide whether we're going to move forward with this older p.r. modifying INSTALL. @nwc10 https://github.com/nwc10, would you like to provide some feedback on @Grinnz https://github.com/Grinnz's comments? — Reply to this email directly, view it on GitHub <#19185 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5R64QXWOASXBN3YCSN3U55VHBANCNFSM5FYZ42WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>
-- perl -Mre=debug -e "/just|another|perl|hacker/"

There's been no discussion in this older pull request since October. @nwc10, do you still want to proceed with it? (Otherwise, I think we should close it.)

nwc10 added 2 commits February 8, 2023 08:04
Change the only instance of I<> to B<> - bold is at least as good for
emphasis, and consistency within the document is good.

Remove the only X<> - a single =head2 had an X<> beneath it, whilst all
others did not. The relevant term, PERL_INTERNAL_RAND_SEED, has equivalent
documentation in other files - there is no need to index it here.
The paragraph starts:

    On a related issue, old modules may possibly be affected by the changes
    in the Perl language in the current release.

Previously it made no indication about whether these changes were frequent
or rare, small or large. The reality is that we are careful to keep them
small and backwards compatible, whenever possible. So add the text:

    We try hard to make new features "opt-in", such that existing code will
    work unchanged, and attempt to identify where bug fixes might expose
    code which was relying on incorrect interpreter behaviour.

Also remind people that the pod/perldelta.pod is only changes for the
current release, hence they should read all the relevant perldelta files
if they are upgrading from a release further back. perldelta already says
this, but INSTALL was not clear.
@demerphq
Copy link
Collaborator

demerphq commented Feb 8, 2023

I have rebased this and split the paragraph as requested by @Grinnz. I believe it should be merged.

@demerphq demerphq merged commit fdce04e into Perl:blead Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants