Test equivalence of 'true' and 'false' to negated statements#19252
Merged
jkeenan merged 1 commit intoPerl:bleadfrom Dec 8, 2021
Merged
Test equivalence of 'true' and 'false' to negated statements#19252jkeenan merged 1 commit intoPerl:bleadfrom
jkeenan merged 1 commit intoPerl:bleadfrom
Conversation
Contributor
Author
|
@leonerd, if you have any objection to this p.r., can you please let us know? Otherwise, I plan to merge it within 3 days. Thank you very much. |
Contributor
|
|
jkeenan
added a commit
to jkeenan/perl5
that referenced
this pull request
Dec 7, 2021
Per review by Paul Evans in Perl#19252
Contributor
Author
Updated. |
leonerd
reviewed
Dec 7, 2021
Contributor
|
Looking good. Will approve when the CIs are happy (accepting that cygwin is never happy lately) |
leonerd
approved these changes
Dec 7, 2021
Contributor
leonerd
left a comment
leonerd
left a comment
There was a problem hiding this comment.
LGTM. (Though please squash to merge)
The documentation for lib/builtin.pm asserts that 'true' is equivalent to !!1 or !0, and that false is equivalent to !!0 or !1. Demonstrate that this is so. Per review by Paul Evans in Perl#19252, we'll use cmp_ok() rather than is() and test for each of 'eq' and '=='.
jkeenan
force-pushed
the
builtin-more-tests-20211201
branch
from
4863b40 to
b2d0d92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for lib/builtin.pm asserts that 'true' is equivalent
to !!1 or !0, and that false is equivalent to !!0 or !1. Demonstrate
that this is so.