regcomp.c: remove experimental status from variable length lookbehind #19454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Karl Williamson for doing the bulk of the work to make this successful. The regex engine is the better for it.
This was referenced Feb 23, 2022
Contributor
|
As I noted elsewhere, I'm not convinced this has had the level of testing out there to justify marking it non-experimental. However I'm unclear on what the criteria really are for that decision, I've no problem with others deciding differently. The alternative of reducing the scope sounds more attractive to me, I'll try to look at that. |
Contributor
|
@demerphq is it safe to assume this PR should be closed now, since the alternative to reduce scope of the experimental status has been merged? |
Collaborator
Author
|
Please keep it, I will push a new set of commits to do the same thing this
branch but on top of the reduced scope patch. I didnt get around to it
today.
cheers,
yves
…On Thu, 3 Mar 2022 at 16:28, Hugo van der Sanden ***@***.***> wrote:
@demerphq <https://github.com/demerphq> is it safe to assume this PR
should be closed now, since the alternative to reduce scope of the
experimental status has been merged?
—
Reply to this email directly, view it on GitHub
<#19454 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZ5RZAPFYZSBO5MDUQZYDU6DLC5ANCNFSM5PDGRMRQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
perl -Mre=debug -e "/just|another|perl|hacker/"
|
Collaborator
Author
|
I am closing this. The existing documentation is good enough I think. If we want to remove its experimental status we probably have to come up with a new experiment category, and this PR does not do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove experimental status for lookbehind. This patch should not be applied until #19442 is merged.