Skip to content

re_op_compile: Coverity ASSIGN_WHERE_COMPARE_MEANT fix #19672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023
Merged

re_op_compile: Coverity ASSIGN_WHERE_COMPARE_MEANT fix #19672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion regcomp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1833,7 +1833,7 @@ Perl_re_op_compile(pTHX_ SV ** const patternp, int pat_count,
* properly currently.
*
*/
while ((OP(first) == OPEN && (sawopen = 1)) ||
while ((OP(first) == OPEN && ((sawopen = 1)) ) ||
/* An OR of *one* alternative - should not happen now. */
(OP(first) == BRANCH && OP(first_next) != BRANCH) ||
/* for now we can't handle lookbehind IFMATCH*/
Expand Down