-
Notifications
You must be signed in to change notification settings - Fork 603
Math-Complex: correct typos in documentation #20210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math-Complex: correct typos in documentation #20210
Conversation
|
This fixes CPAN RT #136653. |
|
This distribution is maintained on CPAN, though permissions have been transferred to P5P, it would need to be moved from cpan/ to dist/ before changes can be made to it in blead. |
|
requires #20215 |
|
Can we have someone handle the content of this pull
Can we have someone handle the content of this pull request? (I or someone else can handle the rebasing, etc., separately once the content is approved.) |
- Correct typo where "pi" should be "phi". - Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi.
33eb973 to
7dcd87a
Compare
|
Having wrapped my head around the Wikipedia article on spherical coordinates -- specifically, around the sidebar on Spherical coordinates (r, θ, φ) as often used in mathematics: -- I believe this patch is correct and should be applied. I will do so within 7 days unless there is some objection. |
|
@jkeenan : the changes look right to me too (and I studied that in the Technion). |
|
Personally I think @Grinnz has a point. I dont think we need to be as strict as he says, we can patch it in cpan/ and THEN move it to dist, provided we actually move it to dist/ in the end. |
|
OH, we have already moved it to dist. |
|
@jkeenan why wait? |
Among other reasons ... at this time of year many people are not reading their email. So giving people (including the OP) a time frame in which to respond does not hurt. (I could give other reasons, but then we would be deep into a policy discussion which should take place on the perl5-porters mailing list.) |
- Correct typo where "pi" should be "phi". - Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi. Committer: lib/Math/Trig.pm: Increment $VERSION For: #20210
|
Handled manually and merged to blead in 7b4ead7. Closing ticket. |
- Correct typo where "pi" should be "phi". - Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi. Committer: lib/Math/Trig.pm: Increment $VERSION For: Perl#20210
- Correct typo where "pi" should be "phi". - Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi. Committer: lib/Math/Trig.pm: Increment $VERSION For: Perl#20210
- Correct typo where "pi" should be "phi". - Spherical coordinates should use the same order of the coordinates everywhere, i.e., rho, theta, phi. Committer: lib/Math/Trig.pm: Increment $VERSION For: Perl#20210
Correct typo where "pi" should be "phi".
Spherical coordinates should use the same order of the coordinates
everywhere, i.e., rho, theta, phi.