Skip to content

Conversation

@pjacklam
Copy link
Contributor

@pjacklam pjacklam commented Sep 1, 2022

  • Correct typo where "pi" should be "phi".

  • Spherical coordinates should use the same order of the coordinates
    everywhere, i.e., rho, theta, phi.

@pjacklam
Copy link
Contributor Author

pjacklam commented Sep 1, 2022

This fixes CPAN RT #136653.

@Grinnz
Copy link
Contributor

Grinnz commented Sep 1, 2022

This distribution is maintained on CPAN, though permissions have been transferred to P5P, it would need to be moved from cpan/ to dist/ before changes can be made to it in blead.

@Grinnz
Copy link
Contributor

Grinnz commented Sep 1, 2022

requires #20215

@jkeenan
Copy link
Contributor

jkeenan commented Oct 1, 2022

Can we have someone handle the content of this pull

  • Correct typo where "pi" should be "phi".

    • Spherical coordinates should use the same order of the coordinates
      everywhere, i.e., rho, theta, phi.

Can we have someone handle the content of this pull request?

(I or someone else can handle the rebasing, etc., separately once the content is approved.)

- Correct typo where "pi" should be "phi".

- Spherical coordinates should use the same order of the coordinates
  everywhere, i.e., rho, theta, phi.
@pjacklam pjacklam force-pushed the pjacklam/math-complex-doc-error-cpan-rt-136653 branch from 33eb973 to 7dcd87a Compare October 12, 2022 17:34
@jkeenan
Copy link
Contributor

jkeenan commented Dec 25, 2022

Having wrapped my head around the Wikipedia article on spherical coordinates -- specifically, around the sidebar on Spherical coordinates (r, θ, φ) as often used in mathematics: -- I believe this patch is correct and should be applied. I will do so within 7 days unless there is some objection.

@jkeenan jkeenan self-assigned this Dec 25, 2022
@shlomif
Copy link
Contributor

shlomif commented Dec 26, 2022

@jkeenan : the changes look right to me too (and I studied that in the Technion).

@demerphq
Copy link
Collaborator

demerphq commented Dec 26, 2022

Personally I think @Grinnz has a point. I dont think we need to be as strict as he says, we can patch it in cpan/ and THEN move it to dist, provided we actually move it to dist/ in the end.

@demerphq
Copy link
Collaborator

OH, we have already moved it to dist.

@demerphq
Copy link
Collaborator

@jkeenan why wait?

@jkeenan
Copy link
Contributor

jkeenan commented Dec 27, 2022

@jkeenan why wait?

Among other reasons ... at this time of year many people are not reading their email. So giving people (including the OP) a time frame in which to respond does not hurt.

(I could give other reasons, but then we would be deep into a policy discussion which should take place on the perl5-porters mailing list.)

jkeenan pushed a commit that referenced this pull request Dec 29, 2022
- Correct typo where "pi" should be "phi".

- Spherical coordinates should use the same order of the coordinates
  everywhere, i.e., rho, theta, phi.

Committer: lib/Math/Trig.pm: Increment $VERSION

For: #20210
@jkeenan
Copy link
Contributor

jkeenan commented Dec 29, 2022

Handled manually and merged to blead in 7b4ead7. Closing ticket.

@jkeenan jkeenan closed this Dec 29, 2022
pjacklam added a commit to pjacklam/perl5 that referenced this pull request May 20, 2023
- Correct typo where "pi" should be "phi".

- Spherical coordinates should use the same order of the coordinates
  everywhere, i.e., rho, theta, phi.

Committer: lib/Math/Trig.pm: Increment $VERSION

For: Perl#20210
pjacklam added a commit to pjacklam/perl5 that referenced this pull request May 20, 2023
- Correct typo where "pi" should be "phi".

- Spherical coordinates should use the same order of the coordinates
  everywhere, i.e., rho, theta, phi.

Committer: lib/Math/Trig.pm: Increment $VERSION

For: Perl#20210
khwilliamson pushed a commit to khwilliamson/perl5 that referenced this pull request Jul 10, 2023
- Correct typo where "pi" should be "phi".

- Spherical coordinates should use the same order of the coordinates
  everywhere, i.e., rho, theta, phi.

Committer: lib/Math/Trig.pm: Increment $VERSION

For: Perl#20210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants