Add a step to the RMG about podcheck #20975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's quick to skim the podcheck summary of errors, and some things, like broken links should really be fixed before the release.
demerphq
requested changes
Mar 28, 2023
Collaborator
demerphq
left a comment
demerphq
left a comment
There was a problem hiding this comment.
I don't entirely get the need for this. As part of the release process we tell people to run test_porting, which runs these checks.
I don't object to it either, I am just not sure why it is needed.
| verbatim lines. | ||
|
|
||
| But other warnings should be. In particular, a broken link can well | ||
| mean that someone clicking on the pod in a web page will get a 404. |
Collaborator
There was a problem hiding this comment.
There should be a blank line after this one and before the next =head3
Contributor
Author
|
The impetus for this was, IIRC, that 5.36.0 shipped with broken links. As the text says, people wrongly silence podcheck warnings, and this adds a quick double check that that hasn't happened. |
Contributor
Author
|
I've added to the text more, but can't get github to accept it without a merge commit. So I'm closing this request, and opening a replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quick to skim the podcheck summary of errors, and some things, like broken links should really be fixed before the release.