Skip to content

Conversation

@rwp0
Copy link
Contributor

@rwp0 rwp0 commented Jan 28, 2024

  • http -> https links
  • Linking modules and sections
  • Apply formatting

@rwp0
Copy link
Contributor Author

rwp0 commented Jan 28, 2024

Finally managed to make a cleaner PR.

Please ignore the previous ones (which I closed).

Copy link
Contributor Author

@rwp0 rwp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made reviews on lines to clarify my points for modification

@Grinnz
Copy link
Contributor

Grinnz commented Jan 28, 2024

Can you also apply these changes to Porting/perldelta_template.pod?

@rwp0 rwp0 force-pushed the rwp0/perldelta-template-fixes branch from 1fe61d1 to a5b0d4a Compare January 29, 2024 10:58
@rwp0
Copy link
Contributor Author

rwp0 commented Jan 29, 2024

@Grinnz thanks, that's done

@rwp0 rwp0 force-pushed the rwp0/perldelta-template-fixes branch from a5b0d4a to 3d4629e Compare January 29, 2024 11:04
- http -> https links
- Linking modules and sections
- Apply formatting
@rwp0 rwp0 force-pushed the rwp0/perldelta-template-fixes branch from 3d4629e to aa5bdd2 Compare January 30, 2024 13:40
@rwp0
Copy link
Contributor Author

rwp0 commented Jan 30, 2024

Thanks for the feedback.

Reverted the changes concerning the apostrophe and formatting in regards to PR notation.

Please merge if all is good now.

@rwp0
Copy link
Contributor Author

rwp0 commented Jan 30, 2024

Not sure why reviews show a red X when I resolved the review myself. @jkeenan could you please re-review?

Screenshot_20240130_221915_GitHub.jpg

@rwp0 rwp0 requested review from jkeenan and khwilliamson January 31, 2024 14:59
@jkeenan jkeenan merged commit b9be37a into Perl:blead Jan 31, 2024
@rwp0 rwp0 deleted the rwp0/perldelta-template-fixes branch February 1, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants