Clear up ambiguous use of 'try block' #23955
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back in 2001 several tests were added to t/op/goto.t which
referred to a concept called a 'try block':
commit 9c5794f
Author: Robin Houston <robin@cpan.org>
AuthorDate: Wed Mar 14 01:52:51 2001 +0000
Commit: Jarkko Hietaniemi <jhi@iki.fi>
CommitDate: Wed Mar 14 02:41:54 2001 +0000
...
diff --git a/t/op/goto.t b/t/op/goto.t
index 246184c..6f9e349 100755
--- a/t/op/goto.t
+++ b/t/op/goto.t
...
+# Does goto work correctly within a try block?
That language is still in use in two files -- but since we now have
a 'try' keyword and a feature 'try', such language is now ambiguous.
Here we change 'try block' to 'eval block' in those test descriptions
and comments where we're clearly speaking about 'eval BLOCK'.
khwilliamson
approved these changes
Nov 23, 2025
iabyn
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in 2001 several tests were added to t/op/goto.t which referred to a concept called a 'try block':
That language is still in use in two files -- but since we now have a 'try' keyword and a feature 'try', such language is now ambiguous.
Here we change 'try block' to 'eval block' in those test descriptions and comments where we're clearly speaking about 'eval BLOCK'.