Skip to content

Clear up ambiguous use of 'try block' #23955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2025
+3 −3
Merged

Clear up ambiguous use of 'try block' #23955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pp_ctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2388,7 +2388,7 @@ PP_wrapped(pp_caller, MAXARG, 0)
mPUSHs(newSVsv(cx->blk_eval.old_namesv));
PUSHs(&PL_sv_yes);
}
/* eval BLOCK (try blocks have old_namesv == 0) */
/* eval BLOCK (eval blocks have old_namesv == 0) */
else {
PUSHs(&PL_sv_undef);
PUSHs(&PL_sv_undef);
Expand Down
4 changes: 2 additions & 2 deletions t/op/goto.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,15 @@ FORL2: for($y=1; 1;) {
goto FORL2;
}

# Does goto work correctly within a try block?
# Does goto work correctly within a eval block?
# (BUG ID 20000313.004) - [perl #2359]
my $ok = 0;
eval {
my $variable = 1;
goto LABEL20;
LABEL20: $ok = 1 if $variable;
};
ok($ok, 'works correctly within a try block');
ok($ok, 'works correctly within a eval block');
is($@, "", '...and $@ not set');

# And within an eval-string?
Expand Down
Loading