Skip to content

Conversation

@khwilliamson
Copy link
Contributor

This reverts commit 6fb21d6 and changes to use PERL_UNUSED_ARG

Fixes #23952.

  • This set of changes does not require a perldelta entry.

This reverts commit 6fb21d6 and changes
to use PERL_UNUSED_ARG to silence the compiler warning that commit was
intended to silence

Fixes Perl#23952.
@khwilliamson khwilliamson requested a review from tonycoz November 25, 2025 13:29
@khwilliamson
Copy link
Contributor Author

@sisyphus Please check this

@sisyphus
Copy link
Contributor

@sisyphus Please check this

Tests fine for me.

@khwilliamson khwilliamson merged commit f3c8c58 into Perl:blead Nov 26, 2025
34 checks passed
@jkeenan
Copy link
Contributor

jkeenan commented Nov 26, 2025

When I click on the link in the first post to this now-merged pull request, I'm taken to a page that has a banner saying, This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository. Where did commit 6fb21d6 exist?

@tonycoz
Copy link
Contributor

tonycoz commented Nov 27, 2025

Where did commit 6fb21d6 exist?

It was part of the original PR #23896 and in the merge process became 9153e0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Win32, MSVC version 143] win32/perllib.c fails to compile as of perl-5.43.5 (on unthreaded builds only)

4 participants