Skip to content

Configure: Allow LC_ALL syntax override #23961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: blead
Choose a base branch
from
+56 −46
Open

Configure: Allow LC_ALL syntax override #23961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73978d8
Configure: Allow LC_ALL syntax override
khwilliamson Nov 25, 2025
b3197ca
Configure: indent, comments
khwilliamson Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 56 additions & 46 deletions Configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17484,14 +17484,16 @@ $rm_try
esac
esac

: Check the syntax of LC_ALL when categories are set to different locales
echo " "
$echo "Checking the syntax of LC_ALL when categories are set to different locales..." >&4
case "$perl_lc_all_separator$perl_lc_all_category_positions_init" in
Copy link

@bram-perl bram-perl Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit message:

I... You need to specify in a hints
file:

 perl_lc_all_separator="correct-value"
perl_lc_all_category_positions_init="correct-value"

Can you add a sensible example for "correct-value"?

"")
: Check the syntax of LC_ALL when categories are set to different locales
echo " "
$echo "Checking the syntax of LC_ALL when categories are set to different locales..." >&4

case $d_setlocale in
$define)
$rm -f try try.*
$cat >try.c <<'EOF'
case $d_setlocale in
$define)
$rm -f try try.*
$cat >try.c <<'EOF'
#include <limits.h>
#include <locale.h>
#include <stdlib.h>
Expand Down Expand Up @@ -17821,45 +17823,53 @@ main (const int argc, const char ** argv)

#endif
EOF
set try
if eval $compile_ok; then
output=`$run ./try 2>/dev/null`
separator=`echo "$output" | $sed 1q`
case $separator in
"\"=;\"")
d_perl_lc_all_uses_name_value_pairs="$define"
d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=
;;
"") d_perl_lc_all_uses_name_value_pairs="$undef"
d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=
;;
*) d_perl_lc_all_uses_name_value_pairs="$undef"
d_perl_lc_all_separator="$define"
perl_lc_all_separator="$separator"
d_perl_lc_all_category_positions_init="$define"
perl_lc_all_category_positions_init=`echo "$output" | sed -n 2p`
;;
esac
else
$echo "Failed to compile lc_all probe" >&4
fi
$rm -f try try.*
;;
*) d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=

# No setlocale(), but using this default allows our code to compile
# and run without having to have a bunch more #ifdef's
d_perl_lc_all_uses_name_value_pairs="$define"
;;
set try
if eval $compile_ok; then
output=`$run ./try 2>/dev/null`
separator=`echo "$output" | $sed 1q`
case $separator in
"\"=;\"")
d_perl_lc_all_uses_name_value_pairs="$define"
d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=
;;
"") d_perl_lc_all_uses_name_value_pairs="$undef"
d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=
;;
*) d_perl_lc_all_uses_name_value_pairs="$undef"
d_perl_lc_all_separator="$define"
perl_lc_all_separator="$separator"
d_perl_lc_all_category_positions_init="$define"
perl_lc_all_category_positions_init=`echo "$output" | sed -n 2p`
;;
esac
else
$echo "Failed to compile lc_all probe" >&4
fi
$rm -f try try.*
;;
*) d_perl_lc_all_separator="$undef"
perl_lc_all_separator=
d_perl_lc_all_category_positions_init="$undef"
perl_lc_all_category_positions_init=

# No setlocale(), but using this default allows our code to
# compile and run without having to have a bunch more #ifdef's
d_perl_lc_all_uses_name_value_pairs="$define"
;;
esac # case on $d_setlocale
;;

*) # Has an lc_all definition passed-in
d_perl_lc_all_separator="$define"
d_perl_lc_all_category_positions_init="$define"
d_perl_lc_all_uses_name_value_pairs="$undef"
;;
esac

: see if pipe2 exists
Expand Down
Loading