Dancer::Test and params()#962
Closed
tomhukins wants to merge 3 commits intoPerlDancer:develfrom
tomhukins:param_and_test
Closed
Dancer::Test and params()#962tomhukins wants to merge 3 commits intoPerlDancer:develfrom tomhukins:param_and_test
tomhukins wants to merge 3 commits intoPerlDancer:develfrom
tomhukins:param_and_test
Conversation
This helps people who mistakenly assume they can pass a source to param() as permitted by params().
Despite what the documentation says, "body" can contain a hash reference as well as a string. See t/23_dancer_tests/02_tests_functions.t for an example use.
Contributor
|
Merged. Thanks! I've however didn't put in the param() check. As we don't do argument checking in the other functions, I just have to think a little longer on how we want to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see http://lists.preshweb.co.uk/pipermail/dancer-users/2013-September/003353.html for details.