TestTool::init: properly handle SDL::init errors #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll features as a bonus
…sleep and made eoq handler modifiable. Added a bunch of tests to controller, still not quite everything is covered. Didn't add anything to app tests, just cleaned them up a little. PODs to come next.
…am methods and fixed a bit of explanation about param methods.
Fix most of the screaming spelling errors in pods
We built the libSDL binaries several years ago, and so it was built against an older runtime library (msvcrt.dll). Now we build SDL itself against msvcr110.dll for example, and therefore allocate on another heap than the free() is taking place, which happens in libSDL_mixer itself. See: http://stackoverflow.com/questions/23257226/sdl-mixer-mix-freechunk-crashing-on-sample-created-in-memory
So far TestTool::init was just capturing stdout and stderr of SDL::init, using stderr to check whether SDL::init failed. This, other than being fragile, misses the init errors. Switch from checking stderr to checking the actual result code of SDL::init.
wchristian
force-pushed
the
master
branch
2 times, most recently
from
37c2c36 to
70134b6
Compare
|
Apparently this got busted somehow, will open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far TestTool::init was just capturing stdout and stderr of SDL::init, using stderr to check whether SDL::init failed. This, other than being fragile, misses the init errors.
Switch from checking stderr to checking the actual result code of SDL::init.