Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

TestTool::init: properly handle SDL::init errors #262

Closed
wants to merge 97 commits into
from

Conversation

Projects
None yet
10 participants

pinotree commented May 4, 2014

So far TestTool::init was just capturing stdout and stderr of SDL::init, using stderr to check whether SDL::init failed. This, other than being fragile, misses the init errors.

Switch from checking stderr to checking the actual result code of SDL::init.

We load this stuff for other reasons.

Why not just get once? at line 148?

Erm .... change this variable name. Confusing. $icon_title.

why undef here? Just seems weird.

same problem with undef. Also I think SDLx::Controller might needs delay(), later on.

Blaizer and others added some commits Aug 24, 2011

cleaned up SDLx::App. Cleaned up SDLx::Controller and added time and …
…sleep and made eoq handler modifiable. Added a bunch of tests to controller, still not quite everything is covered. Didn't add anything to app tests, just cleaned them up a little. PODs to come next.
Forgot time and sleep in the controller pod, forgot shortcuts for par…
…am methods and fixed a bit of explanation about param methods.
Merge pull request #213 from ioanrogers/patch-1
Make SDLx::Music match the docs
SDLx::App icon done and documented but transparency doesn't work.
SDLx::App is just about done now, except for some polish. Needs tests, too...
SDLx::Controller stop_handler and its docs.
Just about finished SDLx::Controller now, too. Needs polish, tests, and... someone to tell me the docs make sense?
SDLx::Controller stop_handler and changed pause to work better. Fixed…
… tests. Rewrote docs. Fixed examples to comply
SDLx::Controller tests for pause, event_handlers and stop_handler
Also some fixes to the docs and a bunch of fixes and cleanup to the pm

Here's the one line max_t does its work.

Owner

kthakore commented on b2d3c89 May 2, 2012

can you link the email or bug report to this?

Owner

FROGGS replied May 2, 2012

Owner

kthakore replied May 2, 2012

Just why did you turn on MMX ?

Member

dod38fr replied May 2, 2012

This commit is related to: #221

Member

Blaizer commented on abd03a3 Jun 9, 2012

Huh...? Why?

Owner

jtpalmer replied Jun 9, 2012

2.538 should have been the same as 2.537_02. We don't want any non-dev releases with changes that haven't been tested with a dev release.

There were both XS and Perl versions of SDLx::Surface::draw_rect and SDLx::Surface::blit, so it looks like there was a problem with a merge.

Check out the test reports:

http://static.cpantesters.org/distro/S/SDL.html#2.538

There was also a thread on the mailing list about this if you missed it:

http://www.nntp.perl.org/group/perl.sdl.devel/2012/05/msg1902.html

I've tried re-merging the changes, but haven't had much success. Feel free giving it a try and we can put out another dev release.

bricas and others added some commits Apr 17, 2013

fix segfault when cleaning up MixChunks on windows
We built the libSDL binaries several years ago, and so it was built
against an older runtime library (msvcrt.dll).
Now we build SDL itself against msvcr110.dll for example, and therefore
allocate on another heap than the free() is taking place, which happens
in libSDL_mixer itself.
See: http://stackoverflow.com/questions/23257226/sdl-mixer-mix-freechunk-crashing-on-sample-created-in-memory

FROGGS and others added some commits May 11, 2014

TestTool::init: properly handle SDL::init errors
So far TestTool::init was just capturing stdout and stderr of SDL::init,
using stderr to check whether SDL::init failed. This, other than being
fragile, misses the init errors.

Switch from checking stderr to checking the actual result code of
SDL::init.

pinotree commented May 1, 2015

Apparently this got busted somehow, will open a new one.

@pinotree pinotree closed this May 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment