Ignore location displayName

[slifty]

This PR removes recognition of the displayName attribute of a location. This is a legacy field we are about to remove, but also it wasn't actually being stored which resulted in unexpected behavior (specifically, the value disappeared on refresh for users)

Resolves #1024

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.02%. Comparing base (cd27bfb) to head (ef0259a).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   49.97%   50.02%   +0.04%     
==========================================
  Files         348      348              
  Lines       11501    11495       -6     
  Branches     1974     1971       -3     
==========================================
+ Hits         5748     5750       +2     
+ Misses       5561     5557       -4     
+ Partials      192      188       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR removes support for the legacy displayName field on location objects so the UI no longer shows an ephemeral value that disappears on refresh (per Issue #1024). The change aligns the frontend’s location model, formatting pipe, and location picker UI around only persisted location fields.

Changes:

• Removed displayName from the LocnVOData model shape.
• Updated PrLocationPipe to stop emitting/concatenating a displayName into the formatted location output.
• Updated the location picker to stop setting and rendering displayName.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/app/shared/pipes/pr-location.pipe.ts	Removes displayName from the pipe output and stops injecting it into the formatted full string.
src/app/models/locn-vo.ts	Removes legacy displayName from the location VO data interface.
src/app/file-browser/components/location-picker/location-picker.component.ts	Stops populating locn.displayName from Google Places place.name.
src/app/file-browser/components/location-picker/location-picker.component.html	Stops rendering currentLocationDisplay.displayName in the location panel.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[aasandei-vsp]

Code wise, the change seems correct. But I have some issues understanding what has changed and where in the UI.

• Where exactly did the displayName appear in the UI?
• Can you give me some steps to reproduce before and after?

This is the research I have done:

A. Location on sidebar(preview and full) On main and also on the branch I had the exact same result. Steps I tried:

1. Select a file
2. Click on "Click to set location"
3. In the search bar, type Breazu.
4. Select "Breazu, Romania, RO"
5. Click save
   EXPECTED: The map updates the pin, the location line says "Breazu, Romania, RO"
   ACTUAL: As expected.
   ?????? Not sure where the display name should be present, taking into account that I saw the same thing on both main and this branch.
6. Refresh the page.
   EXPECTED: The location should show "Breazu, Romania, RO" and the pin on the map should be correct.
   ACTUAL: As expected.
7. Follow steps 2-6 again, but this time type "Iasi" in the search bar
   EXPECTED: The location should show "Iași, IS, RO, RO" and the pin on the map should be correct.
   ACTUAL: The location shows "Breazu, Romania, RO" and the pin on the map is for this location.

B. Location pipe
I have seen it used in the code in 2 places, on the public profile and somewhere in shared, but I cannot get to them in the UI. Could you help me with some steps for that, please?

[slifty]

@aasandei-vsp I believe this only applies to named locations (e.g. landmarks such as "Eiffel Tower"). The landmark name would appear pre-save:

but then disappear on refresh:

Within this branch the landmark name is not rendered at all, just the address.

As for the location pipe, I'll look into it and try to get you instructions there.