PER-9957: Add sharing options to the sharing dialog#511
Merged
crisnicandrei merged 2 commits intomainfrom Jan 10, 2025
Merged
Conversation
meisekimiu
approved these changes
Jan 9, 2025
k8lyn6
requested changes
Jan 9, 2025
Collaborator
k8lyn6
left a comment
k8lyn6
left a comment
There was a problem hiding this comment.
Looking great! Would it be possible to reduce the font size to the small font size we use in the Legacy Planning modal pictured below. Otherwise I think this is good!
Contributor
Author
|
@k8lyn6 of course! I will! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 43.20% 43.27% +0.07%
==========================================
Files 363 363
Lines 11104 11104
Branches 1810 1810
==========================================
+ Hits 4797 4805 +8
+ Misses 6147 6140 -7
+ Partials 160 159 -1 ☔ View full report in Codecov by Sentry. |
k8lyn6
approved these changes
Jan 10, 2025
Collaborator
k8lyn6
left a comment
k8lyn6
left a comment
There was a problem hiding this comment.
That's perfect, thanks Andrei!
Added a text which explains the sharing options in the sharing dialog for the user. Also updated the scss file.
crisnicandrei
force-pushed
the
PER-9957-a-user-should-understand-sharing-options
branch
from
cfbd4cd to
7f80458
Compare
crisnicandrei
deleted the
PER-9957-a-user-should-understand-sharing-options
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a text which explains the sharing options in the sharing dialog for the user. Also updated the scss file.