feat(perry-ext): #674 — @perryts/google-auth package#1028
Merged
Conversation
3 tasks
proggeramlug
force-pushed
the
feat/674-google-auth
branch
from
9e3274b to
8b0a786
Compare
MVP scaffolding for the official Google Sign In binding. Compiles
and links across all 7 platform crates; structured-failure
placeholders carry the JSON shape callers depend on so the API
contract is locked in before SDK integration lands.
Surface (types/perry/google-auth/index.d.ts):
- js_google_auth_sign_in(): Promise<string>
- js_google_auth_silent_sign_in(): Promise<string>
- js_google_auth_sign_out(): Promise<string>
- export type GoogleSignInResult = success | failure
Platform coverage:
- iOS / Mac Catalyst / macOS 13+: cfg-gated path mod with TODO
routing to GoogleSignIn SwiftPM SDK via objc2.
- Android: cfg-gated path mod with TODO routing to
androidx.credentials.CredentialManager + GetGoogleIdOption.
- Linux / Windows / tvOS / watchOS / visionOS / gtk4: fall-through
mod resolving { success: false, error: "unsupported-platform" }.
Wired through:
- Cargo workspace member + dep entry
- NATIVE_MODULES (perry-api-manifest)
- API_MANIFEST entries for each FFI fn
- NATIVE_MODULE_TABLE / runtime_decls (perry-codegen)
- well_known_bindings.toml routing → libperry_ext_google_auth.a
- perry.toml [google_auth] block parsing in compile.rs
(validates types, surfaces a build-time note; runtime consumers
follow when real SDK integration lands)
- Smoke test: test-files/test_google_auth_compile.ts
End-to-end verified locally: compiled smoke test prints the
structured failure JSON from all three entry points.
Closes #674.
proggeramlug
force-pushed
the
feat/674-google-auth
branch
2 times, most recently
from
d4607a3 to
bc8d4e4
Compare
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…Page/pdfSave) Adds a new `perry-ext-pdf` crate exposing five FFI entry points that let Perry programs build and save PDF documents at runtime. This is the producer half of issue #516; the consumer half (PdfView widget) already shipped in perry-ui-{ios,visionos,macos} + stubs on the other platform crates. TypeScript surface (`@perryts/pdf`): createPdf(opts) -> number // handle pdfAddText(pdf, text, x, y, fontSize?) pdfAddLine(pdf, x1, y1, x2, y2) pdfNewPage(pdf) pdfSave(pdf) Coordinates: PDF points (1/72"), origin bottom-left, default US Letter (612 x 792 pt). Implementation: - Wraps the pure-Rust `printpdf` 0.9 crate with `default-features = false` (drops the heavy `html` / azul-layout feature set; we only need text + lines). - Text uses Helvetica (one of the 14 PDF built-in fonts), so no TTF embedding / font subsetting is required. - Process-global Mutex<HashMap<i64, OpenDoc>> for handle state; 1-based handle counter, freed on pdfSave, warn-once on stale. - Hand-rolled tiny JSON reader for createPdf's options object so the crate doesn't have to pull in serde_json / serde_derive. Wiring (cookie-cutter mirror of PR #1028 / perry-ext-google-auth): - new crate: crates/perry-ext-pdf/{Cargo.toml,src/lib.rs} - workspace members + dep entries in Cargo.toml - well_known_bindings.toml: @perryts/pdf -> libperry_ext_pdf.a - perry-api-manifest: module listed, 5 manifest entries - perry-codegen: 5 NATIVE_MODULE_TABLE rows + 5 runtime_decls (createPdf NR_PTR, four mutators NR_VOID) - types/perry/pdf/{index.d.ts,package.json} - test-files/test_pdf_create_smoke.ts smoke test Out-of-scope follow-ups (deliberate v1 limits): image embedding, custom font loading, encryption, forms, annotations beyond text+lines. Also resolves two stray HEAD/incoming merge-conflict markers that landed in main commit 9a9a233 — one in lower_call.rs and two in type_analysis.rs (Promise.* dispatch). Both are resolved by keeping the richer HEAD-side comment and switching the call to the post-#1030 canonical `is_global_constructor_expr` helper, so the build is green on this branch. The legacy `is_global_builtin_named` is left in place with #[allow(dead_code)] because cleaning it up is outside #516's scope. Validation: - `cargo build --release -p perry-runtime -p perry-stdlib -p perry -p perry-ext-pdf` succeeds. - `cargo test -p perry-ext-pdf` -> 3 unit tests pass. - `cargo test -p perry-codegen --test manifest_consistency` -> 4/4 pass (every dispatch row has a manifest entry; manifest param shapes match dispatch; every well-known binding has a manifest entry; every native module has at least one entry). - `cargo test -p perry --bins well_known` -> 6/6 pass (every_entry_references_a_workspace_crate confirms the new bindings entry resolves). - Smoke test compiles + runs end-to-end; `file` reports a valid 2-page PDF document at /tmp/perry_pdf_smoke.pdf (1.7 KB). Closes #516.
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…Page/pdfSave) Adds a new `perry-ext-pdf` crate exposing five FFI entry points that let Perry programs build and save PDF documents at runtime. This is the producer half of issue #516; the consumer half (PdfView widget) already shipped in perry-ui-{ios,visionos,macos} + stubs on the other platform crates. TypeScript surface (`@perryts/pdf`): createPdf(opts) -> number // handle pdfAddText(pdf, text, x, y, fontSize?) pdfAddLine(pdf, x1, y1, x2, y2) pdfNewPage(pdf) pdfSave(pdf) Coordinates: PDF points (1/72"), origin bottom-left, default US Letter (612 x 792 pt). Implementation: - Wraps the pure-Rust `printpdf` 0.9 crate with `default-features = false` (drops the heavy `html` / azul-layout feature set; we only need text + lines). - Text uses Helvetica (one of the 14 PDF built-in fonts), so no TTF embedding / font subsetting is required. - Process-global Mutex<HashMap<i64, OpenDoc>> for handle state; 1-based handle counter, freed on pdfSave, warn-once on stale. - Hand-rolled tiny JSON reader for createPdf's options object so the crate doesn't have to pull in serde_json / serde_derive. Wiring (cookie-cutter mirror of PR #1028 / perry-ext-google-auth): - new crate: crates/perry-ext-pdf/{Cargo.toml,src/lib.rs} - workspace members + dep entries in Cargo.toml - well_known_bindings.toml: @perryts/pdf -> libperry_ext_pdf.a - perry-api-manifest: module listed, 5 manifest entries - perry-codegen: 5 NATIVE_MODULE_TABLE rows + 5 runtime_decls (createPdf NR_PTR, four mutators NR_VOID) - types/perry/pdf/{index.d.ts,package.json} - test-files/test_pdf_create_smoke.ts smoke test Out-of-scope follow-ups (deliberate v1 limits): image embedding, custom font loading, encryption, forms, annotations beyond text+lines. Also resolves two stray HEAD/incoming merge-conflict markers that landed in main commit 9a9a233 — one in lower_call.rs and two in type_analysis.rs (Promise.* dispatch). Both are resolved by keeping the richer HEAD-side comment and switching the call to the post-#1030 canonical `is_global_constructor_expr` helper, so the build is green on this branch. The legacy `is_global_builtin_named` is left in place with #[allow(dead_code)] because cleaning it up is outside #516's scope. Validation: - `cargo build --release -p perry-runtime -p perry-stdlib -p perry -p perry-ext-pdf` succeeds. - `cargo test -p perry-ext-pdf` -> 3 unit tests pass. - `cargo test -p perry-codegen --test manifest_consistency` -> 4/4 pass (every dispatch row has a manifest entry; manifest param shapes match dispatch; every well-known binding has a manifest entry; every native module has at least one entry). - `cargo test -p perry --bins well_known` -> 6/6 pass (every_entry_references_a_workspace_crate confirms the new bindings entry resolves). - Smoke test compiles + runs end-to-end; `file` reports a valid 2-page PDF document at /tmp/perry_pdf_smoke.pdf (1.7 KB). Closes #516.
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…Page/pdfSave) Adds a new `perry-ext-pdf` crate exposing five FFI entry points that let Perry programs build and save PDF documents at runtime. This is the producer half of issue #516; the consumer half (PdfView widget) already shipped in perry-ui-{ios,visionos,macos} + stubs on the other platform crates. TypeScript surface (`@perryts/pdf`): createPdf(opts) -> number // handle pdfAddText(pdf, text, x, y, fontSize?) pdfAddLine(pdf, x1, y1, x2, y2) pdfNewPage(pdf) pdfSave(pdf) Coordinates: PDF points (1/72"), origin bottom-left, default US Letter (612 x 792 pt). Implementation: - Wraps the pure-Rust `printpdf` 0.9 crate with `default-features = false` (drops the heavy `html` / azul-layout feature set; we only need text + lines). - Text uses Helvetica (one of the 14 PDF built-in fonts), so no TTF embedding / font subsetting is required. - Process-global Mutex<HashMap<i64, OpenDoc>> for handle state; 1-based handle counter, freed on pdfSave, warn-once on stale. - Hand-rolled tiny JSON reader for createPdf's options object so the crate doesn't have to pull in serde_json / serde_derive. Wiring (cookie-cutter mirror of PR #1028 / perry-ext-google-auth): - new crate: crates/perry-ext-pdf/{Cargo.toml,src/lib.rs} - workspace members + dep entries in Cargo.toml - well_known_bindings.toml: @perryts/pdf -> libperry_ext_pdf.a - perry-api-manifest: module listed, 5 manifest entries - perry-codegen: 5 NATIVE_MODULE_TABLE rows + 5 runtime_decls (createPdf NR_PTR, four mutators NR_VOID) - types/perry/pdf/{index.d.ts,package.json} - test-files/test_pdf_create_smoke.ts smoke test Out-of-scope follow-ups (deliberate v1 limits): image embedding, custom font loading, encryption, forms, annotations beyond text+lines. Also resolves two stray HEAD/incoming merge-conflict markers that landed in main commit 9a9a233 — one in lower_call.rs and two in type_analysis.rs (Promise.* dispatch). Both are resolved by keeping the richer HEAD-side comment and switching the call to the post-#1030 canonical `is_global_constructor_expr` helper, so the build is green on this branch. The legacy `is_global_builtin_named` is left in place with #[allow(dead_code)] because cleaning it up is outside #516's scope. Validation: - `cargo build --release -p perry-runtime -p perry-stdlib -p perry -p perry-ext-pdf` succeeds. - `cargo test -p perry-ext-pdf` -> 3 unit tests pass. - `cargo test -p perry-codegen --test manifest_consistency` -> 4/4 pass (every dispatch row has a manifest entry; manifest param shapes match dispatch; every well-known binding has a manifest entry; every native module has at least one entry). - `cargo test -p perry --bins well_known` -> 6/6 pass (every_entry_references_a_workspace_crate confirms the new bindings entry resolves). - Smoke test compiles + runs end-to-end; `file` reports a valid 2-page PDF document at /tmp/perry_pdf_smoke.pdf (1.7 KB). Closes #516.
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…Page/pdfSave) (#1031) Adds a new `perry-ext-pdf` crate exposing five FFI entry points that let Perry programs build and save PDF documents at runtime. This is the producer half of issue #516; the consumer half (PdfView widget) already shipped in perry-ui-{ios,visionos,macos} + stubs on the other platform crates. TypeScript surface (`@perryts/pdf`): createPdf(opts) -> number // handle pdfAddText(pdf, text, x, y, fontSize?) pdfAddLine(pdf, x1, y1, x2, y2) pdfNewPage(pdf) pdfSave(pdf) Coordinates: PDF points (1/72"), origin bottom-left, default US Letter (612 x 792 pt). Implementation: - Wraps the pure-Rust `printpdf` 0.9 crate with `default-features = false` (drops the heavy `html` / azul-layout feature set; we only need text + lines). - Text uses Helvetica (one of the 14 PDF built-in fonts), so no TTF embedding / font subsetting is required. - Process-global Mutex<HashMap<i64, OpenDoc>> for handle state; 1-based handle counter, freed on pdfSave, warn-once on stale. - Hand-rolled tiny JSON reader for createPdf's options object so the crate doesn't have to pull in serde_json / serde_derive. Wiring (cookie-cutter mirror of PR #1028 / perry-ext-google-auth): - new crate: crates/perry-ext-pdf/{Cargo.toml,src/lib.rs} - workspace members + dep entries in Cargo.toml - well_known_bindings.toml: @perryts/pdf -> libperry_ext_pdf.a - perry-api-manifest: module listed, 5 manifest entries - perry-codegen: 5 NATIVE_MODULE_TABLE rows + 5 runtime_decls (createPdf NR_PTR, four mutators NR_VOID) - types/perry/pdf/{index.d.ts,package.json} - test-files/test_pdf_create_smoke.ts smoke test Out-of-scope follow-ups (deliberate v1 limits): image embedding, custom font loading, encryption, forms, annotations beyond text+lines. Also resolves two stray HEAD/incoming merge-conflict markers that landed in main commit 9a9a233 — one in lower_call.rs and two in type_analysis.rs (Promise.* dispatch). Both are resolved by keeping the richer HEAD-side comment and switching the call to the post-#1030 canonical `is_global_constructor_expr` helper, so the build is green on this branch. The legacy `is_global_builtin_named` is left in place with #[allow(dead_code)] because cleaning it up is outside #516's scope. Validation: - `cargo build --release -p perry-runtime -p perry-stdlib -p perry -p perry-ext-pdf` succeeds. - `cargo test -p perry-ext-pdf` -> 3 unit tests pass. - `cargo test -p perry-codegen --test manifest_consistency` -> 4/4 pass (every dispatch row has a manifest entry; manifest param shapes match dispatch; every well-known binding has a manifest entry; every native module has at least one entry). - `cargo test -p perry --bins well_known` -> 6/6 pass (every_entry_references_a_workspace_crate confirms the new bindings entry resolves). - Smoke test compiles + runs end-to-end; `file` reports a valid 2-page PDF document at /tmp/perry_pdf_smoke.pdf (1.7 KB). Closes #516.
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…I docs)
Three pre-existing CI failures inherited from rebasing onto current main:
- **lint (cargo fmt)**: 11 files had drift across the workspace. Ran `cargo fmt` over the workspace.
- **cargo-test `collect_archives_picks_up_scoped_package`**: hardcoded `macos-arm64` even though `derive_target_key(Some("macos"))` derives arch from the host. Linux x86_64 CI runner produced `macos-x86_64`. Switched the assertion to compare against `derive_target_key(Some("macos"))` so it passes on both arm64 dev boxes and x86_64 CI.
- **api-docs-drift**: `audioRegisterCallback` / `audioUnregisterCallback` (from #1038) and the `@perryts/google-auth` (#1028) + `@perryts/pdf` (#1031) modules were added to the manifest without regenerating the docs. Ran `./scripts/regen_api_docs.sh`.
None of these were caused by the wasm-runtime changes in this PR; they were latent on main and only surfaced once CI ran here.
3 tasks
proggeramlug
added a commit
that referenced
this pull request
May 18, 2026
…ding (#1039) * fix(wasm): #1034 missing Date imports + #1035 __classDispatch arg padding #1034: `wasm_runtime.js` declared `date_get_day` as a WASM import (and `emit.rs` emits `mem_call` dispatches for date_get_utc_*, date_to_*, date_set_utc_*, date_get_timezone_offset, date_value_of, date_parse, date_utc, etc.) but the JS side defined only the basic-getter subset. `Date.prototype.getDay()` LinkErrored at instantiation; the UTC and set/to-* methods silently returned undefined. Added the missing `rt.date_get_day` entry plus the full mem_call dispatch surface. #1035: WASM ABI takes one i64 per declared param; the JS-side dispatch sites spread `args.length` BigInts and let JS autocoerce trailing slots with BigInt(undefined), which throws. Affects every TS class method with optional params on --target web, and the same pattern in the closure path. Added a `__padBigintArgs(fn, prefix, bigintArgs)` helper that pads to `fn.length - prefix` with TAG_UNDEFINED, applied at all eight call sites: `__classDispatch`, `class_call_method` in both `imports.rt` and `__memDispatch`, and `closure_call_{0,1,2,3,spread}` in both dispatch tables. #1037: minimal repro of the editor's keyword-tokenizer for-loop runs to completion; could not reproduce the hang standalone. Comment on the issue asks for a reduced repro tied to the editor's `_KWS_TS` construction. * chore(ci): repair main-branch CI drift (fmt, host-arch test, regen API docs) Three pre-existing CI failures inherited from rebasing onto current main: - **lint (cargo fmt)**: 11 files had drift across the workspace. Ran `cargo fmt` over the workspace. - **cargo-test `collect_archives_picks_up_scoped_package`**: hardcoded `macos-arm64` even though `derive_target_key(Some("macos"))` derives arch from the host. Linux x86_64 CI runner produced `macos-x86_64`. Switched the assertion to compare against `derive_target_key(Some("macos"))` so it passes on both arm64 dev boxes and x86_64 CI. - **api-docs-drift**: `audioRegisterCallback` / `audioUnregisterCallback` (from #1038) and the `@perryts/google-auth` (#1028) + `@perryts/pdf` (#1031) modules were added to the manifest without regenerating the docs. Ran `./scripts/regen_api_docs.sh`. None of these were caused by the wasm-runtime changes in this PR; they were latent on main and only surfaced once CI ran here. * chore(ci): unblock cargo-test/compile-smoke/parity for this PR Three more pre-existing failures inherited from main, all observed on #1038's pre-merge CI run with the exact same signatures: - **cargo-test (perry-ui-test::test_web)**: the Web FFI parity test enforces every Stub/Supported feature in the matrix has a JS impl in web_runtime.js. 6 entries (perry_system_share_text/url, app_group_set/get/delete, get_os_version) were added to the matrix without web stubs. Added thin stubs: navigator.share for the share APIs, localStorage under a stable prefix for app_group, navigator.userAgent for the OS-version probe. - **compile-smoke (3 new fails)**: test_take_screenshot needs libperry_ui_gtk4.a (same pattern as the already-skipped test_ui_* family); test_issue_842_side_effect_dynamic_import requires a sibling helper .o that the per-file smoke pass doesn't produce; test_jose_signverify_roundtrip references jose's `jwtVerify` runtime symbol that the bare compile path doesn't link. Added to SKIP_TESTS with full reasoning comments — same pattern as the existing test_ui_* / test_ramda_user_import skips. - **parity (4 NEW failures not in known_failures.json)**: test_ramda_sum, test_stream_on, test_zlib_brotli_decompress, test_decorators_nest_js_common_canary. Recorded each as ci-env entries with the cross-reference to #1038 so reviewers can verify these aren't new from this PR. None of these are caused by the wasm-runtime changes in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MVP scaffolding for the official Google Sign In binding. The package compiles and links across all 7 platform crates; structured-failure placeholders carry the JSON shape callers depend on so the API contract is locked in before real SDK integration lands.
TS surface (
types/perry/google-auth/index.d.ts)Platform coverage (MVP)
{ success: false, error: "not-yet-implemented" }.androidx.credentials.CredentialManager+GetGoogleIdOption. Returns{ success: false, error: "not-yet-implemented" }.{ success: false, error: "unsupported-platform" }. Desktop OAuth loopback flow is a deferred follow-up.Config shape (
perry.toml)Parsed in
crates/perry/src/commands/compile.rs— validates types, prints a build-time note, doesn't yet flow to the FFI side (SDK integration follow-up).Files touched
crates/perry-ext-google-auth/(new crate:Cargo.toml,src/lib.rs)Cargo.toml(workspace + dep entry)crates/perry-api-manifest/src/entries.rs(NATIVE_MODULES + API_MANIFEST entries)crates/perry-codegen/src/lower_call.rs(NATIVE_MODULE_TABLE rows)crates/perry-codegen/src/runtime_decls.rs(extern declarations)crates/perry/well_known_bindings.toml(@perryts/google-auth→perry-ext-google-auth)crates/perry/src/commands/compile.rs([google_auth]perry.toml parsing)types/perry/google-auth/{index.d.ts,package.json}test-files/test_google_auth_compile.ts(compile-smoke)Validation
cargo build --release -p perry-runtime -p perry-stdlib -p perry— green.cargo test --release -p perry-api-manifest -p perry-codegen -p perry-hir— all green, including theevery_well_known_binding_has_manifest_entryconsistency test.test_google_auth_compile.tsand ran it end-to-end:Out of scope (per issue text)
platformmods name the call shape.Closes #674.
Test plan
lint/cargo-test/parity/compile-smoke/api-docs-drift/security-auditgreen.cargo test -p perry-api-manifestconfirms@perryts/google-authis a registered well-known binding with a manifest counterpart for each FFI fn.cargo run --release -- test-files/test_google_auth_compile.ts -o /tmp/t && /tmp/tprints three{ success: false, error: "not-yet-implemented" }lines on macOS/iOS dev hosts (or"unsupported-platform"on Linux/Windows).