fix(perf_hooks): structured-clone mark/measure detail (#1340)#1440
Merged
Conversation
mark(name, { detail }) / measure(name, { detail }) now structured-clone
detail via js_structured_clone, so the entry's detail deep-equals the
input but is a distinct reference (mutating the original afterward no
longer mutates the stored entry), matching Node. Flips both
node-suite/perf_hooks/{mark,measure}/detail-structured-clone to PASS;
the detail-option tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performance.mark(name, { detail })andperformance.measure(name, { detail })should structured-clonedetail(node:perf_hooks gap #1340, umbrella #793). Perry stored the same reference, som.detail === input(and mutating the original mutated the stored entry).option_detail_bitsnow routes the value throughjs_structured_clone, so the storeddetaildeep-equals the input but is a distinct reference — matching Node.Test
Flips both
test-parity/node-suite/perf_hooks/mark/detail-structured-cloneand.../measure/detail-structured-cloneto PASS (one root, both removed fromknown_failures.json); thedetail-optiontests still pass.Closes #1340.