test(parity): stream — consolidated consumers/promises/static batch (iter-145..152, supersedes 7 PRs)#1751
Merged
Conversation
…batches 28–34, iter-145..152) Aggregates 7 previously-separate batch PRs (#1733/#1737/#1739/#1743/#1744/#1745/#1748) into one for easier merging. 29 new stream parity tests across: - stream/consumers (text/json/buffer/blob/arrayBuffer, web-RS sources): confirmed at full parity — every test passes - stream/promises (finished/pipeline variants): mostly passing - stream/static helpers: surfaced concrete impl gaps (isWritable, getDefaultHighWaterMark, setDefaultHighWaterMark unimplemented; isErrored post-destroy) 11 tracked failures in known_failures.json, the static-helper cluster tracked under granular issue #1746. All passing tests need no entry. Phantom failures from a broken direct-verify binary (.on('data') events dropped) were already excluded — only synchronous + await-based results, which are reliable, are included here.
This was referenced May 25, 2026
4 tasks
proggeramlug
added a commit
that referenced
this pull request
May 25, 2026
7 PRs landed on main after the v0.5.1027 bump (50c391f) without per-PR tags. Neither v0.5.1026 nor v0.5.1027 were tagged on the remote — v0.5.1028 is the first tag in this window. - #1738 feat(compile): --trace/--focus debugging flags. - #1723/#1741 fix(lockdown): #503 ns[dynamicKey].staticMember. - #1673/#1742 fix(dynamic-import): literal node: builtin specifier. - #1724/#1747 fix(node): Blob/URL globals trigger http-client feature. - #1728/#1749 fix(node:path): win32 normalize/basename/toNamespacedPath. - #1751 test(parity): stream consumers/promises/static batch. - #1754 test(node-core): enrich common shim for #800.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated stream parity batch — consumers / promises / static (iter-145..152)
Aggregates 7 previously-separate batch PRs (#1733, #1737, #1739, #1743, #1744, #1745, #1748) into one for easier merging. 29 new stream parity tests.
stream/consumers(text/json/buffer/blob/arrayBuffer, incl. Web-RS sources)stream/promises(finished/pipeline variants)stream/statichelpers11 tracked failures in
known_failures.json— the static-helper cluster (isWritable,getDefaultHighWaterMark,setDefaultHighWaterMarkunimplemented;isErrorednot flipping post-destroy(err);isReadable(non-stream)returningfalsevs Node'snull) is filed as granular issue #1746 with these tests as the spec. Passing tests carry no entry.Phantom failures from a broken direct-verify binary (auto-optimized runtime silently dropped
.on('data')events) were already excluded — only synchronous andawait-based comparisons, which are reliable regardless of that binary quirk, are included.Supersedes #1733/#1737/#1739/#1743/#1744/#1745/#1748 (closing those in favor of this).