test(node-core): #1842 pre-warm + workspace-cwd so http/net/https are measurable#1846
Merged
Conversation
Under --auto-optimize the radar could not link the perry-ext-* server crates (http/net/https), so those tests false-bucketed as compile-fail. Two causes, both fixed here: 1. cwd: auto-optimize locates the Cargo workspace from the process cwd to (re)build the ext crates. The runner compiled from a temp `bin/` dir, so auto-optimize silently skipped the ext-crate build and link-failed. Now --auto-optimize compiles run from the perry workspace (REPO_ROOT); the `.o` litter there is gitignored (`*.o`). 2. cold-build timeout: the first compile needing an ext crate cold-builds heavy deps (hyper/tokio/openssl/flate2). A one-time kitchen-sink pre-warm (http/https/net/zlib/crypto) builds them up front so each per-feature relink in the sweep is incremental, not cold. Validated (http, --max-per-api 10): http 0%→62.5%, compile-fail 6→0. The prior http 5% / net 10% / https 0% were entirely this artifact. Closes #1842.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1842 (follow-up to #1778). Tooling-only (radar runner).
Under
--auto-optimizethe radar couldn't link theperry-ext-*server crates, so http/net/https tests false-bucketed as compile-fail. Two causes:bin/dir → auto-optimize silently skipped the ext-crate build and link-failed. Now--auto-optimizecompiles run from the perry workspace (.olitter is gitignored).Validated (http, 10 tests): http 0%→62.5%, compile-fail 6→0. The earlier http 5% / net 10% / https 0% were entirely this artifact — real parity there is far higher. Once merged, a full sweep gives a trustworthy network-inclusive parity number.