fix(runtime): implement assert throws helpers#1924
Merged
proggeramlug merged 1 commit intoMay 27, 2026
Conversation
f562ee6 to
e8c8d12
Compare
e8c8d12 to
63b983c
Compare
This was referenced May 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert.throwsandassert.doesNotThrowfornode:assertandnode:assert/strictVerification
./run_parity_tests.sh --suite node-suite --module assert --filter generated-message/throws-generatedPASS./run_parity_tests.sh --suite node-suite --module assert --filter errors/throwsPASS 2/2./run_parity_tests.sh --suite node-suite --module assert --filter errors/strict-throws-validationPASS./run_parity_tests.sh --suite node-suite --module assertPASS threshold: 55 pass / 8 fail / 0 compile failcargo test -p perry-runtime assert --libPASScargo test -p perry-codegen manifest_consistency --libPASSbash scripts/regen_api_docs.shPASScargo fmt --all -- --checkPASSgit diff --checkPASSjq empty test-parity/known_failures.jsonPASSResidual full-suite assert failures are unrelated lanes: deep equality edge cases, async
rejects, and CallTracker version skew. Full dynamic Error property storage is also left out of this slice.