Skip to content

fix(node:stream): consolidate destroy state#1925

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-stream-destroy-state-clean
May 27, 2026
Merged

fix(node:stream): consolidate destroy state#1925
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-stream-destroy-state-clean

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • initialize typed stream stubs with destroyed: false
  • expose stream.destroyed through the native runtime getter
  • make destroy(err) return the stream immediately and mark errored state on the microtask queue
  • retain the destroy-state stream runtime symbols across optimized builds

Supersedes #1910 and #1911.

Verification

  • cargo fmt --all --check
  • ./scripts/check_file_size.sh
  • git diff --check origin/main...HEAD
  • jq empty test-parity/known_failures.json
  • cargo test -p perry-runtime node_stream --lib -- --nocapture
  • cargo test -p perry-codegen manifest_consistency --lib

@andrewtdiz andrewtdiz force-pushed the codex/node-stream-destroy-state-clean branch 5 times, most recently from 7217f60 to 29e9242 Compare May 27, 2026 06:34
@andrewtdiz andrewtdiz force-pushed the codex/node-stream-destroy-state-clean branch from 29e9242 to a6fb5b4 Compare May 27, 2026 06:43
@proggeramlug proggeramlug merged commit 1f2dca2 into PerryTS:main May 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants