fix(node): throw for child_process sync failures#1949
Merged
proggeramlug merged 1 commit intoMay 27, 2026
Merged
Conversation
e7d2dbb to
e1df594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
child_process.execSyncandexecFileSyncthrow when the child exits non-zero.status,signal,output,pid,stdout, andstderrfields.node-suite/child_process/sync/nonzero-throwparity fixture covering success paths, stderr capture,execFileSyncargs, and both sync failure helpers.Verification
PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module child_process --filter nonzero-throwfailed because Perry printedexecSync no throw: outwhere Node enteredcatch.PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module child_process --filter nonzero-throwPASS.PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module child_processPASS 1/1.PERRY_NO_CACHE=1 ./run_parity_tests.sh --filter test_parity_child_processPASS.cargo test -p perry-runtime child_process --libPASS with pre-existing warnings.cargo fmt --all -- --checkPASS.jq empty test-parity/known_failures.jsonPASS.git diff --checkPASS.Non-goals
encodingoption parity (node:child_process — exec/execFile/sync ignore the encoding option (no Buffer stdout/stderr) #1937).spawnSyncresult expansion (node:child_process — spawnSync result missing pid/signal/output/error fields #1936).exec/execFilefailure Error shape (node:child_process — exec/execFile failure Error missing .code/.signal/.killed/.cmd #1935).