fix(node): honor child_process exec buffer encoding#1956
Merged
proggeramlug merged 1 commit intoMay 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #1937.
Summary
child_process.exec()/execFile()encoding: "buffer"andencoding: nullfor callback stdout/stderr values.exec(..., { encoding: "buffer" }),execFile(..., { encoding: null }), and default string output.Baseline
encoding: "buffer"andencoding: null.Buffer.isBuffer(stdout)was false andstdout.toString("hex")returned the original text instead of hex bytes.Reference
reference/deepwiki/deno-node-child-process-exec-encoding-buffer-2026-05-27.md.encoding: "buffer"ornullproduces Buffer stdout/stderr;execsharesexecFileencoding behavior.Tests
PERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module child_process --filter exec-encoding-bufferPERRY_NO_CACHE=1 ./run_parity_tests.sh --suite node-suite --module child_processPERRY_NO_CACHE=1 ./run_parity_tests.sh --filter test_parity_child_processcargo test -p perry-runtime child_process --libcargo fmt --all -- --checkjq empty test-parity/known_failures.jsongit diff --checkNon-goals
execSync/execFileSyncreturn ABI changes.spawnSyncBuffer-vs-string result output shape.hex, unknown-encoding fallback behavior, or full encoding validation.