fix(node:stream): honor Readable.from options#2248
Merged
proggeramlug merged 2 commits intoMay 29, 2026
Merged
Conversation
# Conflicts: # test-parity/known_failures.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Readable.from(iterable, options)lowering to a two-argument runtime helperReadable.fromdefaults:objectMode: trueandhighWaterMark: 1objectMode: falseandhighWaterMark, and remove the two now-passing known failuresDeepWiki
reference/deepwiki/nodejs-node-readable-from-options-2026-05-28.mdconfirmsReadable.from()defaults object mode on, uses HWM 1, and reflects options throughreadableObjectMode/readableHighWaterMarkVerification
node-suite/stream/readable/from-with-options, reporttest-parity/reports/parity_report_20260528_082348.jsonnode-suite/stream/readable/static-from-with-options, reporttest-parity/reports/parity_report_20260528_082426.jsonfrom-with-options, reporttest-parity/reports/parity_report_20260528_083023.jsonstatic-from-with-options, reporttest-parity/reports/parity_report_20260528_083106.jsonfrom-with-options, reporttest-parity/reports/parity_report_20260528_083126.jsonstatic-from-with-options, reporttest-parity/reports/parity_report_20260528_083131.jsonnode-suite/stream/readable/from-iterable-iteration, reporttest-parity/reports/parity_report_20260528_083309.jsoncargo test -p perry-runtime readable_from_uses_node_object_mode_and_high_water_mark_defaultscargo check -p perry-runtime -p perry-stdlib -p perry-codegencargo fmt --checkjq empty test-parity/known_failures.jsongit diff --checkNon-goals
Readable.fromstate-machine rewriteobjectMode/highWaterMarkbehavior