Skip to content

fix(node:zlib): expose stream close method values#2260

Merged
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-zlib-stream-close-property
May 29, 2026
Merged

fix(node:zlib): expose stream close method values#2260
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-zlib-stream-close-property

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • expose function-valued close and destroy property reads on zlib stream handles
  • add a granular parity fixture for zlib.createGzip() method property shape

Part of #793.

Evidence

  • Baseline exact node-suite/zlib/streams/close-destroy-method-values: FAIL, report test-parity/reports/parity_report_20260528_095304.json
  • Final exact node-suite/zlib/streams/close-destroy-method-values: PASS, report test-parity/reports/parity_report_20260528_095459.json
  • Full granular node-suite/zlib: PASS 47/47, report test-parity/reports/parity_report_20260528_095516.json
  • cargo check -p perry-runtime -p perry-stdlib -p perry-codegen: PASS with existing warnings
  • cargo fmt --check: PASS
  • jq empty test-parity/known_failures.json: PASS
  • git diff --check: PASS

DeepWiki

  • reference/deepwiki/nodejs-node-zlib-stream-method-values-2026-05-28.md

Non-goals

  • no lifecycle callback or close-callback semantics
  • no full Transform inheritance rewrite
  • no .params() / .reset() / .bytesWritten work
  • no zstd implementation

# Conflicts:
#	crates/perry-stdlib/src/common/dispatch.rs
@proggeramlug proggeramlug merged commit ae66ff1 into PerryTS:main May 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants