test(parity): bisect #1635 gap-bisect bundles — 3 pass, 2 split into #2277/#2278#2279
Merged
Merged
Conversation
Five `test-parity/known_failures.json` entries were filed against #1635 ("gap-bisect backlog: pin failing sub-cases in 5 bundle probes"). Result: - `test_edge_regression` — now byte-identical, REMOVED. - `test_gap_array_methods` — now byte-identical, REMOVED. - `test_jsruntime_mixed_async_ordering_matrix` — source file no longer exists in `test-files/`, REMOVED. - `test_edge_type_narrowing` — single residual: `typeof === "string"` narrowing on `string | number[]` leaves the else-branch mis-typed as string so `.join` throws. Repointed to #2277. - `test_gap_class_advanced` — single residual: static class block assigning `true` to a declared `static initialized: boolean` field reads back `0`. Repointed to #2278. Three of the five bundles silently passed on intervening parity work; the two residuals are now scoped down to one specific failing sub-case each, which #2277 / #2278 track with focused repros. Refs #1635.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bisected the 5
gap-bisectbundles filed against #1635:test_edge_regressiontest_gap_array_methodstest_jsruntime_mixed_async_ordering_matrixtest-files/test_edge_type_narrowingtest_gap_class_advancedResiduals
typeof === "string"narrowing onstring | number[]leaves the else-branch mis-typed as string, so.joinlowers as a string method and throws. The rest of the file (control-flow narrowing, discriminated-union dispatch,in-operator narrowing) passes.trueto a static boolean field reads back0(init missed) #2278: astatic {}block assigningtrueto a declaredstatic initialized: booleanreads back0instead oftrue. The rest of the advanced-class probes (private brand checks, decorator metadata, etc.) pass.Net effect: three bundles cleared, two bundle entries downgraded from "fan-out gap-bisect" to "focused per-feature bug" (category
bug-open).Test plan
cargo fmt --all -- --checkclean (only a JSON edit).BYTE-IDENTICALtonode --experimental-strip-types.trueto a static boolean field reads back0(init missed) #2278) reproduces only the single isolated sub-case noted.Refs #1635.